1848892 - Does not restore Firefox window to correct virtual desktop anymore

Status: UNCONFIRMED

(Firefox :: Session Restore, defect)

Description

[hjkaye]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/116.0

Steps to reproduce:

Start Firefox 116.0.2 and restore session with virtual desktops on Windows 11.

Actual results:

Firefox Windows since 116.0.2 update does not restore Firefox windows to the correct virtual desktop anymore.

Expected results:

Each Firefox window should restore back to the correct virtual desktops that it was moved to. It was working properly before the update.

Currently, when clicking on the taskbar button, all windows pop up instead of just the windows moved to that virtual desktop.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Session Restore' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:dao, could you have a look please?

For more information, please visit BugBot documentation.

Comment 3

[Monica Chiorean]

I was not able to reproduce issue on Win11x64 using FF build 116.0.2 (for me all tabs and windows got restored on their closed Desktop).
Reporter can you please add more detailed steps to description? Thank you.

Comment 4

[Monica Chiorean]

If no update will be provided, issue will be closed as incomplete. Thank you.

Comment 5

[hjkaye]

It appears to be an intermittent bug. Sometimes the FF windows drop into the correct virtual desktop, other times they all show up on all desktops, sometimes it's a mix of the two.

It's Windows 11 Virtual desktop support here. When it was working properly, you could click on the desktop button on the taskbar, and on the screen pops up with all open MS/Windows app windows, and you can drag app windows to the desired desktop.

When FF is restarted and the previous session is restored, it USED to return each of the FF windows to the proper virtual desktop.

Since the problem started, it seems random. Sometimes on FF startup every window goes to the correct desktop. Sometimes they are all on one desktop, sometimes they are showing on all desktops (that's an option in the virtual desktop support, you can right click on a window, there are a couple of options. Show this window on all desktops, and show windows from this app on all desktops). Sometimes it's a mix. I haven't been able to establish if there is any pattern to the variations.

When I first reported it, I did not realize the problem was intermittent.

At one point, I thought it had been resolved by the most recent update, turns out it was (likely) just one startup of FF that happened to work correctly. Pretty sure it's just FF with the problem, although I don't run many other apps with many multiple windows, so can't be 100% certain, however I haven't run across it with any other application.

Currently running 119.0.1 Windows 11 22H2

Comment 6

[William]

This still happens with Firefox 121.0b4 on Kubuntu 23.04

Comment 7

[Dão Gottwald [:dao]]

Hey hjkaye, you said this started happening in 116, but also that it's intermittent. How sure are you this actually started in 116? It would be interesting to know if this is a regression in Firefox or perhaps in Windows. Could you perhaps try to reproduce this in 115? You can download it here: https://ftp.mozilla.org/pub/firefox/releases/115.0/win64/en-US/
Even better yet, could you perhaps pin down a regression range using the mozregression tool?

Comment 8

[Dão Gottwald [:dao]]

(In reply to William from comment #6)

This still happens with Firefox 121.0b4 on Kubuntu 23.04

Could you please file a new bug specifically for Kubuntu, as this bug was focused on Windows?

Comment 9

[William]

New bug submitted as:

• https://bugzilla.mozilla.org/show_bug.cgi?id=1886996

Comment 10

[Dão Gottwald [:dao]]

(In reply to Dão Gottwald [:dao] from comment #7)

Hey hjkaye, you said this started happening in 116, but also that it's intermittent. How sure are you this actually started in 116? It would be interesting to know if this is a regression in Firefox or perhaps in Windows. Could you perhaps try to reproduce this in 115? You can download it here: https://ftp.mozilla.org/pub/firefox/releases/115.0/win64/en-US/
Even better yet, could you perhaps pin down a regression range using the mozregression tool?

Adrian, could QA please help us out with this?

Comment 11

[Adrian Florinescu [:aflorinescu] [PTO until Aug 26]]]

I've been testing W10(22h2)/W11(21h2) behavior with session restore and window position and during light profile usage, couldn't reproduce it. That is assuming that the Open Previous windows and tabs is used and that the session is properly closed -> for tests I used quit firefox.

That being said, there are scenarios/timings in which session restore would not correctly behave and for which mishaps with the latest changes are not saved in the session restore accordingly and interestingly enough on win11 the restore on virtual desktop seemed to be less stable now than with 115 for example. It is at best hightly intermittent, I managed to reproduce only once with latest nightly 126/127, insufficient for any regression range.

I'm not using windows virtual desktops on a regular basis, but there also might be conflicts with how the virtual desktop is set to behave (I've been operating on the default windows setups).

I will do some more investigation here when time is available, I'm curious to see on a low end machine with a heavy usage profile how session restore behaves.

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

Redirect a needinfo that is pending on an inactive user to the triage owner.
:sfoster, since the bug doesn't have a severity set, could you please set the severity or close the bug?

For more information, please visit BugBot documentation.

Comment 13

[Sam Foster [:sfoster] (he/him)]

:aflorinescu, we log out the workspaceID when restoring a session - which should correspond to the virtual desktop on Windows. If you can set browser.sessionstore.loglevel to Debug next time you are testing this, the log files in {profile}/sessionstore-logs/ may tell us at least if this is a session restore problem or the moveToWorkspace call isn't actually succeeding - which would make it a widget problem.