1848904 - Adding a folder type flag does not add the folder's descendants to unified/smart folders

Status: RESOLVED FIXED

(MailNews Core :: General, defect)

Description

[Geoff Lankow (:darktrojan)]

If a folder is created with a folder type flag (e.g. Archive) it is automatically added to the unified folder for that flag. After bug 378833, we also add the descendants of that folder to the unified folder.

However if a folder that already exists is given a flag, it gets added to the unified folder but its descendants do not. This can happen in some obscure cases as an account is set up.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1848904 - Check a folder and its descendants are added to/removed from virtual folders when flags change. r=#thunderbird-reviewers

If a folder's flag changes, or a folder already with a flag is added or removed, it AND its
descendants should be added to the appropriate virtual folder. This patch tests that and fixes
some inconsistent behaviour.

In reality for most folder types this is a very rare occurrence, and for some it would never
happen, but it might as well work the same way for all types.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/601bb5f64dcb
Check a folder and its descendants are added to/removed from virtual folders when flags change. r=mkmelin

Comment 3

[Geoff Lankow (:darktrojan)]

Comment on attachment 9349159 [details]
Bug 1848904 - Check a folder and its descendants are added to/removed from virtual folders when flags change. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined:
Testing completed (on c-c, etc.): in 118
Risk to taking this patch (and alternatives if risky):

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9349159 [details]
Bug 1848904 - Check a folder and its descendants are added to/removed from virtual folders when flags change. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr115

Comment 5

[Daniel Darnell [:dandarnell]]

Thunderbird 115.3.0:
https://hg.mozilla.org/releases/comm-esr115/rev/b7853cdbea29