1849038 - Fix wpt flexbox-align-self-baseline-horiz-006.xhtml

Status: RESOLVED FIXED

(Core :: Layout: Flexbox, defect)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

After bug 1818933, this test is supposed to render correctly on Firefox. However, there is a < 1px vertical offset (probably due to font) in the second "last baseline" subtest between the test and reference files.

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

http://wpt.live/css/css-flexbox/flexbox-align-self-baseline-horiz-006.xhtml

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1849038 - Fix flexbox-align-self-baseline-horiz-006.html. r?dholbert

After bug 1818933, this test is supposed to render correctly on Firefox.
However, there is a < 1px vertical offset (probably due to font) in the second
"last baseline" subtest between the test and reference files.

This patch makes the top edge of the lime "ortho" block touch the flex
container's content top edge in the test file. This doesn't change the purpose
of the second subtest for the last baseline alignment.

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: Bug 1849038: Fix reference case for WPT flexbox-align-self-baseline-horiz-006.xhtml to remove magic/imprecise margin-top hack. r?TYLin

This WPT doesn't robustly pass in any browser before this patch now -- it's
off by 1px in Firefox, and it shows a similar misalignment in Chrome on Ubuntu
if you zoom in the testcase and the reference case.

This is becuase the test has a fragile dependency on using 'margin-top:4px' as
a fudge-factor to bottom-align some content. But that content's size is
font-dependent, so there's no guarantee that 4px will be the right amount to
make it bottom-aligned.

In this patch, I'm fixing the reference case to properly bottom-align the
relevant elements, by using a flex container with align-items:end. This
should make the test more robust, such that it can be expected to pass,
regardless of the font that's used.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cdc41ab01ece
Fix reference case for WPT flexbox-align-self-baseline-horiz-006.xhtml to remove magic/imprecise margin-top hack. r=TYLin

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/41523 for changes under testing/web-platform/tests

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/cdc41ab01ece

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot