1849039 - Add DualSense support to Gamepad API

Status: VERIFIED FIXED

(Core :: DOM: Device Interfaces, enhancement)

Description

[Miha Lepej [:lepko]]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/116.0

Steps to reproduce:

I tried to play a browser game that has controller support and my DualSense controller did not work as expected. Other controller like Xbox One/Series controllers work. You can test the Gamepad API here https://hardwaretester.com/gamepad and you see that the controller is not properly mapped.

The controller works correctly in other browsers (Chrome, Edge).

Actual results:

When you have the DualSense controller connected the Gamepad API does not recognize it as a standard controller.

You get broken data, for example the d-pad does not work and the right stick vertical axis is broken and connected to the trigger instead.

Expected results:

DualSense controller should be recognized as a standard controller and the buttons and other inputs should be correctly mapped.

Comment 1

[Miha Lepej [:lepko]]

I'm actually currently working on a patch to add a GamepadRemapper that supports the GameSense controller and will submit a patch shortly.

Comment 2

[Miha Lepej [:lepko]]

Attachment: Bug 1849039 - Add DualSense support to Gamepad API.

Comment 3

[BugBot [:suhaib / :marco]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 4

[filip.tronicek]

You get broken data, for example the d-pad does not work and the right stick vertical axis is broken and connected to the trigger instead.

I can confirm the D-pad is not being registered as any of the buttons, but rather as gamepad.axes[4]. When connected wirelessly, the controller also reports 14 buttons and when connected with a cable, it reports 15 (the mic mute button).

I'm actually currently working on a patch to add a GamepadRemapper that supports the GameSense controller and will submit a patch shortly.

I tried building Firefox locally with your patch from Phabricator applied, but sadly did not see a difference between what the device was capable of before and after the change. There is a 90% probability that I did something wrong as this is my first time building from a patch, but wanted to mention my troubles. Is there something else required besides running ./mach build when considering the changes to dom/gamepad/?

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e52c91cea1e5
https://hg.mozilla.org/integration/autoland/rev/cdba92ee8979
Add DualSense support to Gamepad API. r=jesup

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/cdba92ee8979

Comment 7

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined/Reason for urgency: PS5 gamepads don't work in Firefox
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: This should only affect users with PS5 controllers. This has also been baking in Nightly for a while.
• String changes made/needed?: no
• Is Android affected?: no

Comment 8

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1849039 - Add DualSense support to Gamepad API.

Original Revision: https://phabricator.services.mozilla.com/D186387

Comment 9

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/6e949e9101f5
https://hg.mozilla.org/releases/mozilla-release/rev/ccbfab11c5f5

Comment 10

[Negritas Sergiu, Desktop QA]

Hello! I can confirm that the issue is fixed with firefox 153.0b3 and 152.0.2 on Ubuntu 24.04 and Windows 11 using the website provided in the description with the dual sense controller.

I will update the flags and status of this issue accordingly.

Have a nice dya