1849056 - Need to handle allocation failures when using `CryptoBuffer::ToArrayBuffer()`

Status: RESOLVED FIXED

(Core :: DOM: Web Authentication, defect, P3)

Comment 1

[John Schanck [:jschanck]]

Attachment: Bug 1849056 - handle failures of CryptoBuffer::ToArrayBuffer. r?tschuster

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/536420808253
handle failures of CryptoBuffer::ToArrayBuffer. r=tschuster,webidl,smaug

Comment 3

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/16e06af20b97
Backed out changeset 536420808253 for bustages on AuthenticatorResponse.cpp

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Push with failure
Failure log

dom/webauthn/AuthenticatorResponse.cpp:41:10: error: member access into incomplete type 'ErrorResult'

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/08d512674485
handle failures of CryptoBuffer::ToArrayBuffer. r=tschuster,webidl,smaug

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/08d512674485

John, which other branches are impacted by this bug? And can we get a sec rating on this?

Comment 7

[John Schanck [:jschanck]]

Sorry, I thought I had tagged this as sec-low already. All branches are affected.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for ESR115 approval. It grafts cleanly.

Comment 9

[John Schanck [:jschanck]]

Comment on attachment 9349313 [details]
Bug 1849056 - handle failures of CryptoBuffer::ToArrayBuffer. r?tschuster

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration:
• User impact if declined: None
• Fix Landed on Version: 118
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The patch has been tested on Nightly and only affects error handling under extreme memory pressure.

Comment 10

[Pascal Chevrel:pascalc]

Comment on attachment 9349313 [details]
Bug 1849056 - handle failures of CryptoBuffer::ToArrayBuffer. r?tschuster

Approved for 118.0b7, thanks.

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/bf57507edde5