Closed Bug 1849177 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 41513 - Fix `mach test-wpt` to make crash tests work

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox119 fixed)

RESOLVED FIXED
119 Branch
Tracking Status
firefox119 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 41513 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/41513
Details from upstream follow.

Mukilan Thiyagarajan <mukilan@igalia.com> wrote:

Fix mach test-wpt to make crash tests work

There are two issues related to crash tests:

  1. test-wpt is unable to find existing crash tests even when called with --test-types=crashtests. The fix here is to add crashtests to the default test suite types to python/wpt/run.py
  2. When running in headless mode, crashes in style threads don't cause servo to crash because the logic in constellation.rs currently calls handle_panic only when the top-level browsing context id is some value. Since style pool threads are shared, they always generate Panic messages with None as top-level browsing context id.

<!-- Please describe your changes on the following line: -->

Reviewed in servo/servo#29832

The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
Test result changes from PR not available.
Test result changes from PR not available.
Test result changes from PR not available.
Test result changes from PR not available.
Test result changes from PR not available.
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/537e3f8e5fd3 [wpt PR 41513] - Fix `mach test-wpt` to make crash tests work, a=testonly
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 119 Branch
You need to log in before you can comment on or make changes to this bug.