1849194 - Enable Shopping API for non-Nightly builds as well

Status: RESOLVED FIXED

(Fenix :: Shopping, task, P1)

Description

[[:owlish] 🦉 PST]

For now the code runs on Nightly only. We will need to essentially roll back this patch before shipping to enable the API for non-Nightly builds.

Comment 1

[Cathy Lu [:calu]]

Attachment: Bug 1849194 - Enable Shopping feature in non-nightly, and remove pref

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed7eb7f23834
Enable Shopping feature in non-nightly, and remove pref r=geckoview-reviewers,tthibaud

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/ed7eb7f23834

Comment 4

[Cathy Lu [:calu]]

Comment on attachment 9361648 [details]
Bug 1849194 - Enable Shopping feature in non-nightly, and remove pref

Beta/Release Uplift Approval Request

User impact if declined: Beta builds will not have the Shopping feature be default, and experiments will be delayed.
Is this code covered by automated tests?: Yes
Has the fix been verified in Nightly?: Yes
Needs manual test from QE?: No
If yes, steps to reproduce:
List of other uplifts needed: None
Risk to taking this patch: Low
Why is the change risky/not risky? (and alternatives if risky): This patch enables Shopping features that have been tested in GeckoView and Fenix during the nightly cycles. 
String changes made/needed: No
Is Android affected?: Yes

Beta/Release Uplift Approval Request

• User impact if declined: Shopping features will not be on default in beta, and experiments will be delayed.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Shopping features have been enabled in nightly and tested in Fenix and GeckoView.
• String changes made/needed:
• Is Android affected?: Yes

Comment 5

[Cathy Lu [:calu]]

Attachment: Bug 1849194 - Enable Shopping feature in non-nightly, and remove pref

Original Revision: https://phabricator.services.mozilla.com/D192593

Comment 6

[Phabricator Automation]

Uplift Approval Request

• Explanation of risk level: hopping features have been enabled in nightly and tested in Fenix and GeckoView.
• Fix verified in Nightly: yes
• String changes made/needed: None
• User impact if declined: Shopping features will not be on default in beta, and experiments will be delayed.
• Is Android affected?: yes
• Steps to reproduce for manual QE testing: N/A
• Code covered by automated testing: yes
• Risk associated with taking this patch: Low
• Needs manual QE test: no

Comment 7

[Dianna Smith [:diannaS]]

Comment on attachment 9361853 [details]
Bug 1849194 - Enable Shopping feature in non-nightly, and remove pref

Approved for 120.0b7
Approved for Mobile 120.0b6

Comment 8

[Cathy Lu [:calu]]

Attachment: WIP: Bug 1849194 - Enable Shopping feature in non-nightly, and remove pref

Original Revision: https://phabricator.services.mozilla.com/D192593

Comment 9

[Dianna Smith [:diannaS]]

Comment on attachment 9361648 [details]
Bug 1849194 - Enable Shopping feature in non-nightly, and remove pref

Approved for 120.0b7

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/0e4c1aabb1e8