Closed Bug 1849204 Opened 10 months ago Closed 10 months ago

Provide a generic AtomHashKey and RefPtrAtomHashKey

Categories

(Core :: XPCOM, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
118 Branch
Tracking Status
firefox118 --- fixed

People

(Reporter: mstange, Assigned: emilio)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [sp3])

Attachments

(1 file)

I'm filing this bug as per Emilio's request in this review comment:

  using MapType = nsTHashMap<nsPtrHashKey<nsAtom>, MiscContainer*>;

Atoms have a pre-computed hash which is probably better distributed than nsPtrHashKey. But I see we don't have a ready-to-use hash key implementation for them. I guess AtomKey from nsGridContainerFrame.h would do, but that uses mozilla::HashMap.

Let's add a generic AtomHashKey and RefPtrAtomHashKey.

Flags: needinfo?(emilio)
Assignee: nobody → emilio
Flags: needinfo?(emilio)
Blocks: 1844470
Blocks: 1849386
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ca63a8d55dbc
Add generic atom hash keys that use the better distributed atom hash, and use it across the tree. r=mstange,xpcom-reviewers,credential-management-reviewers,sgalich,nika
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → 118 Branch
Whiteboard: [sp3]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: