1849234 - Page loads are blocked from completing until `isProductUrl` completes

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Shopping, defect)

Description

[Jonathan Almeida [:jonalmeida]]

Steps to reproduce

1. Enable shopping experience on Nightly.
2. Navigate to a Product List Page (PLP).
3. Click on a Product Details Page (PDP).
4. Observe the progress bar.

Expected behavior

• Checking isProductUrl should not block the progress load of the page.

Actual behavior

• The page progress is incomplete until the response comes back from the service behind isProductUrl. This can take several extra seconds on my local high-end device with high quality wifi.

Device information

• Firefox version: Fenix Nightly 118.0a1 (831cee7e13+)
• Android device model: Pixel 6a
• Android OS version: Android 13

Any additional information?

Logging below was added at the AC layer where we observe, but it seems that the blocking is on the GeckoView layer.

2023-08-17 16:32:01.605 28782-28782 GeckoEngineSession      org.mozilla.fenix.debug              D  JONNN PROGRESS CHANGE: 15
2023-08-17 16:32:01.611 28782-28782 GeckoEngineSession      org.mozilla.fenix.debug              D  JONNN PAGE START
2023-08-17 16:32:02.033 28782-28782 GeckoEngineSession      org.mozilla.fenix.debug              D  JONNN ONPRODUCTURL
2023-08-17 16:32:02.382 28782-28782 GeckoEngineSession      org.mozilla.fenix.debug              D  JONNN PROGRESS CHANGE: 80
2023-08-17 16:32:02.883 28782-28782 GeckoEngineSession      org.mozilla.fenix.debug              D  JONNN ONPRODUCTURL
2023-08-17 16:32:05.975 28782-28782 GeckoEngineSession      org.mozilla.fenix.debug              D  JONNN ONPRODUCTURL
2023-08-17 16:32:06.025 28782-28782 GeckoEngineSession      org.mozilla.fenix.debug              D  JONNN ONPRODUCTURL
2023-08-17 16:32:08.686 28782-28782 GeckoEngineSession      org.mozilla.fenix.debug              D  JONNN PROGRESS CHANGE: 100
2023-08-17 16:32:08.695 28782-28782 GeckoEngineSession      org.mozilla.fenix.debug              D  JONNN PAGE STOP

Comment 1

[Jonathan Almeida [:jonalmeida]]

This seems to be the offending code that should probably be async: https://searchfox.org/mozilla-central/rev/d81e60336d9f498ad3985491dc17c2b77969ade4/mobile/android/modules/geckoview/GeckoViewNavigation.sys.mjs#635-639

Comment 2

[Cathy Lu [:calu]]

Attachment: Bug 1849234 - isProductUrl should be async to prevent blocking page loads

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/88b66d101d4d
isProductUrl should be async to prevent blocking page loads r=geckoview-reviewers,owlish

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/88b66d101d4d