1849236 - Send a shopping component displayed Event

Status: RESOLVED FIXED

(Firefox :: Shopping, task)

Description

[Perry McManis [:perry.mcmanis]]

If the Shopping component sidebar is displayed, send an event.

Comment 1

[Perry McManis [:perry.mcmanis]]

Attachment: Bug 1849236 - Send a shopping component displayed Event r?jhirsch,travislong

Comment 2

[Perry McManis [:perry.mcmanis]]

Attachment: Bug 1849236 - Send a shopping component displayed Event r?jhirsch,travislong

Comment 3

[Perry McManis [:perry.mcmanis]]

Adding some context provided to me by jhirsch:

There are a lot of cases we need to capture

• polling for data
• error from the server (could be rate limiting or generic server outage or, I guess, anything else, like fetch timeout due to latency)
• products either reported deleted, or considered deleted by fakespot but reported as re-activated by the user
• product doesn't have analysis, we've never seen it before
• product doesn't have analysis--because there aren't enough reviews (tricky to infer this from the API)
• product has data but it's stale
• (note also, not represented in the API response but coming soon: product is an unsupported category like groceries or gift cards)

Bruce, on the product doesn't have analysis, do you anticipate these needing to be separate or would you be ok with them being merged?

Comment 4

[Perry McManis [:perry.mcmanis]]

We will want to capture the states as per comment 3, but we will do that as a followup (see the bug that this one blocks).

Comment 5

[Bruce Etling]

(In reply to Perry McManis [:perry.mcmanis] from comment #3)

Adding some context provided to me by jhirsch:

There are a lot of cases we need to capture

• polling for data
• error from the server (could be rate limiting or generic server outage or, I guess, anything else, like fetch timeout due to latency)
• products either reported deleted, or considered deleted by fakespot but reported as re-activated by the user
• product doesn't have analysis, we've never seen it before
• product doesn't have analysis--because there aren't enough reviews (tricky to infer this from the API)
• product has data but it's stale
• (note also, not represented in the API response but coming soon: product is an unsupported category like groceries or gift cards)

Bruce, on the product doesn't have analysis, do you anticipate these needing to be separate or would you be ok with them being merged?

Perry just following up here on comment 3 and your most recent comment. It sounds right to have a general displayed event ping and then to have as many of the details on the state as extras. Fine to implement those extras as a follow on in my view.

Comment 6

[Perry McManis [:perry.mcmanis]]

Hey Bruce, currently I have this setup to fire when a session is restored (i.e. someone who has their browser set to bring back up their prior state would send a sideBarDisplayed when they did so). It would NOT send one when a user switches to a different tab, then comes back, as that starts to feel too decoupled from user web navigation.

Does this work for you? If not please lmk what configuration you would like for these two scenarios.

Comment 7

[Bruce Etling]

That works for me Perry.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ce363f0e95d
Send a shopping component displayed Event r=jhirsch,TravisLong

Comment 9

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/9ce363f0e95d