1849275 - undefined reference to `void mozilla::ImplCycleCollectionTraverse<RefPtr<nsINode> >(nsCycleCollectionTraversalCallback&, mozilla::ContentIteratorBase<RefPtr<nsINode> >&, char const*, unsigned int)'

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Mike Hommey [:glandium]]

Depending on optimizations, the build may fail with:

[task 2023-08-17T21:30:26.663Z] 21:30:26     INFO -  /builds/worker/fetches/binutils/bin/ld.bfd: /builds/worker/workspace/obj-build/toolkit/library/gtest/../../../dom/base/Unified_cpp_dom_base5.o: in function `mozilla::ScriptableContentIterator::cycleCollection::TraverseNative(void*, nsCycleCollectionTraversalCallback&)':
[task 2023-08-17T21:30:26.664Z] 21:30:26     INFO -  /builds/worker/checkouts/gecko/dom/base/ScriptableContentIterator.cpp:(.text._ZN7mozilla25ScriptableContentIterator15cycleCollection14TraverseNativeEPvR34nsCycleCollectionTraversalCallback+0x54): undefined reference to `void mozilla::ImplCycleCollectionTraverse<RefPtr<nsINode> >(nsCycleCollectionTraversalCallback&, mozilla::ContentIteratorBase<RefPtr<nsINode> >&, char const*, unsigned int)'
[task 2023-08-17T21:30:26.664Z] 21:30:26     INFO -  /builds/worker/fetches/binutils/bin/ld.bfd: libxul.so: hidden symbol `_ZN7mozilla27ImplCycleCollectionTraverseI6RefPtrI7nsINodeEEEvR34nsCycleCollectionTraversalCallbackRNS_19ContentIteratorBaseIT_EEPKcj' isn't defined
[task 2023-08-17T21:30:26.664Z] 21:30:26     INFO -  /builds/worker/fetches/binutils/bin/ld.bfd: final link failed: bad value

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1845215

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1849275 - Move template function definition to header.

Template functions declared in headers, defined in one compilation unit
and used from multiple compilation units are a minefield. There is no
guarantee that all the used variants are instantiated from the compilation
unit containing the definition.

One way to deal with such issues is to add explicit instantiations in
the defining compilation unit, but here it causes problems, so we opt to
move the functions to the header.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4f39c21263f
Move template function definition to header. r=masayuki

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e4f39c21263f