1849316 - Refactor `TabManager` methods to make use of `getTabsForWindow` method

Status: RESOLVED FIXED

(Remote Protocol :: Agent, task, P3)

Description

[Alexandra Borovova [:Sasha]]

In the scope of this revision, we've introduced a new method getTabsForWindow. Now some other methods in the TabManager can be simplified and start using getTabsForWindow method.

Comment 1

[dharmateja]

I would like to work on this

Comment 2

[Alexandra Borovova [:Sasha]]

Hey :dharmateja, I hope you have all information to start working on the bug. If not, please don't hesitate to ask questions!

Comment 3

[Guillermo]

Hi! Don't know if this has been fixed, but I've refactored the code. If still open, i'll go ahead and proceed with testing (need to read up on documentation)

Comment 4

[Guillermo]

I see dharmateja has expressed interest in this very recently. I'll be here as a backup just in case :)

Comment 5

[Alexandra Borovova [:Sasha]]

Hi dharmateja! Are you still interested in working on this bug?
Guillermo also showed the interested, and he made some progress already.
So maybe we could find you another bug, if you haven't started here yet.
Let us know! Thanks!

Comment 6

[Nagendra]

Attachment: Bug 1849316 - Refactor `TabManager` methods to make use of `getTabsForWindow` method. r?Sasha

Comment 7

[Nagendra]

Hey! Since it was already more than 10 days since somebody showed interest and as there was no patch, I was working on it. @Sasha, could you please review the patch and let me know if any changes are required?

Comment 8

[Nagendra]

Reupdated the patch to simplify code structure. Please review and update if any changes are required @Sasha @whimboo

Comment 9

[Alexandra Borovova [:Sasha]]

@Nagendra, thanks a lot for the contribution! I've reviewed your patch and left some comments, please take a look.

Comment 10

[Nagendra]

Thank you for pointing out those great points. I've made changes accordingly, the code looks much better now. Please review and update at your convenience.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8764c1d64dab
Refactor `TabManager` methods to make use of `getTabsForWindow` method. r=Sasha,webdriver-reviewers

Comment 12

[Nagendra]

Very glad to know my first contribution got accepted. Thanks, @Sasha for your helpful guide.

May I ask what happens next?
Is the code already integrated into the main codebase?

Comment 13

[Alexandra Borovova [:Sasha]]

(In reply to Nagendra from comment #12)

Very glad to know my first contribution got accepted. Thanks, @Sasha for your helpful guide.

May I ask what happens next?
Is the code already integrated into the main codebase?

Sure, I'm happy to explain :)
It's now on so called autoland, something like an integration branch. And eventually this branch will be merged to central (the main branch). That usually happens twice in 24 hours, so your code should be there in the next hours. There will be a comment here about it and then the bug will be closed.

Comment 14

[Alexandra Borovova [:Sasha]]

Btw, @Nagendra, If you are maybe interested to contribute more into our area, there here a couple of more bugs with JavaScript: https://codetribute.mozilla.org/languages/javascript?project%3DWebDriver%2520BiDi. For example, for this bug I'm also a mentor :). There are also bugs with Python and Rust, if you want to try something else. So let us know if you see anything interesting.

Comment 15

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/8764c1d64dab