1849332 - Fix remaining https-scheme failures in url/url-setters-stripping tests

Status: RESOLVED FIXED

(Core :: DOM: Networking, defect, P2)

Description

[Jonathan Kew [:jfkthame]]

Bug 1818374 resolved most of the failures here, but there are a couple of remaining ones, as found in the url-setters-stripping.any.js.ini metadata file:

  [Setting port with leading U+0000 (https:)]
  [Setting port with leading U+001F (https:)]

It seems these are failing because URL::SetPort uses nsAString::ToInteger() to parse the port number, but this method skips over initial non-numeric (actually non-hexadecimal) characters in the string.

However, to be valid as a a value for the port setter, the string would need to begin with an ASCII digit, afaict:

https://url.spec.whatwg.org/#dom-url-port
https://url.spec.whatwg.org/#port-state

So we should check that before passing the string to ToInteger.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1849332 - Ensure URL::SetPort rejects values with leading non-numeric junk. r=#necko-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00adce290a8f
Ensure URL::SetPort rejects values with leading non-numeric junk. r=necko-reviewers,valentin

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/00adce290a8f