1849336 - Combine SrcNoteType::StepSep with SrcNoteType::Breakpoint

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Tooru Fujisawa [:arai]]

SrcNoteType::StepSep and SrcNoteType::Breakpoint are emitted at the same time:

https://searchfox.org/mozilla-central/rev/d81e60336d9f498ad3985491dc17c2b77969ade4/js/src/frontend/BytecodeEmitter.cpp#218,223,227

bool BytecodeEmitter::markStepBreakpoint() {
...
  if (!newSrcNote(SrcNoteType::StepSep)) {
...
  if (!newSrcNote(SrcNoteType::Breakpoint)) {

and the only consumer of SrcNoteType::StepSep is the following, where SrcNoteType::Breakpoint is also handled.

https://searchfox.org/mozilla-central/rev/d7a8eadc28298c31381119cbf25c8ba14b8712b3/js/src/vm/BytecodeUtil-inl.h#215-221

} else if (type == SrcNoteType::Breakpoint) {
  isBreakpoint = true;
  lastLinePC = snpc;
} else if (type == SrcNoteType::StepSep) {
  seenStepSeparator = true;
  lastLinePC = snpc;
}

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1849336 - Replace SrcNoteType::StepStep + SrcNoteType::Breakpoint with combined SrcNoteType::BreakpointStepStep. r?bthrall!

SrcNoteType::StepStep is always followed by SrcNoteType::Breakpoint,
and there's no need to emit them separately.

Depends on D186918

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2518234cf015
Replace SrcNoteType::StepStep + SrcNoteType::Breakpoint with combined SrcNoteType::BreakpointStepStep. r=bthrall

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/2518234cf015