1849362 - [High Contrast] The "Privacy policy" and "Terms of use" links from the Fakespot onboarding sidebar disappear when clicked

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Rares Doghi, Desktop QA]

Attachment: 2023-08-18_05h02_07.mp4

Found in

• Nightly 118.0a1 (2023-08-18)

Affected versions

• Nightly 118.0a1 (2023-08-18)

Affected platforms

• Windows

Preconditions:
Set the browser.shopping.experience2023.enabled - TRUE
Set the toolkit.shopping.useOHTTP - TRUE
Enable High Contrast

Steps to reproduce

1. Reach about:preferences and turn off feature recommendations.
2. Reach the Amazon https://www.amazon.com/dp/B09B6ZXD2V/ref=sbl_dpx_office-desks_B0B4CYW8FB_0 link
3. Click and Hold each link from the Onboarding Shopping sidebar.

Expected result

• The Text should still be visible.

Actual result

• The Text from each link disappears.

Regression range
Not Applicable

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:rdoghi, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[:Gijs (he/him)]

I wonder if this is the default visited link colour not playing well with the background colour. Do we have this problem on other pages (e.g. the MPL link on about:rights), too?

Comment 3

[:Gijs (he/him)]

Ni for the previous comment (sorry!)

Comment 4

[Rares Doghi, Desktop QA]

No, this issue does not occur on about:rights or about:preferences, there only the underline will disappear.

Comment 5

[Anna Yeddi [:ayeddi]]

Thank you for catching it, Rares!

On HCM, we do not expect to change the color of visited links, at least for now. Thus, they should keep Moznativehypelink foreground and Canvas background color combination.

Comment 6

[Anna Yeddi [:ayeddi]]

It appears that the issue here comes from the markup that uses <a> element (without valid href) with role="button" (discussed in bug 1849577)thus the default theme overrides the foreground color...

Comment 7

[:Gijs (he/him)]

I think the use of role=button here may have changed? Negin ?

Comment 8

[Negin]

(In reply to :Gijs (he/him) from comment #7)

I think the use of role=button here may have changed? Negin ?

It hasn't yet - that bug was prioritized as a P3. I have a WIP patch but it needs more work but I'll re-prioritize it this week, sorry for the delay!

Comment 9

[Negin]

This is also reproducible with the "Not Now" button on the opt-in screen and seems unrelated to role="button". In the inspector I can see the active-state is using var(--link-color-active) and it seems contained to anything that uses text-link-styles mixin and may have been regressed by https://bugzilla.mozilla.org/show_bug.cgi?id=1832855

Comment 10

[Negin]

Attachment: Bug 1849362 - [High Contrast] The "Privacy policy" and "Terms of use" links from the Fakespot onboarding sidebar disappear when clicked

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d3c4ff7d2722
[High Contrast] The "Privacy policy" and "Terms of use" links from the Fakespot onboarding sidebar disappear when clicked r=omc-reviewers,aminomancer

Comment 12

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/d3c4ff7d2722

Comment 13

[Rares Doghi, Desktop QA]

This issue is verified as fixed in our latest Nightly build 119.0a1 (2023-09-24). However in other places when we click a Link the underline will disappear indicating that it's been clicked (about:preferences) should we not have the same behavior here as well ? There is no indication that we are clicking those links. ? Is this ok ?

Comment 14

[Negin]

I believe this is as expected (and is the current state for about:welcome and Spotlight modals). Underline should persist on all states from the following two bugs that were filed:

• general bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1821788
• about:welcome bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1832855

But I'll let Anna chime in in case the active state wasn't defined properly.

Comment 15

[Anna Yeddi [:ayeddi]]

(In reply to Negin from comment #14)

I believe this is as expected (and is the current state for about:welcome and Spotlight modals). Underline should persist on all states from the following two bugs that were filed:

• general bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1821788
• about:welcome bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1832855

But I'll let Anna chime in in case the active state wasn't defined properly.

Thank you! The underline is expected to be present in all states (confirmed with the Design systems team too). And the links are readable on HCM when :active and in other states too - thank you all for the investigation and work on the bug!