1849365 - The Not Now button from the Fakespot Onboarding sidebar is missing the Clicked State

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Rares Doghi, Desktop QA]

Attachment: NotNow.mp4

Found in

• Nightly 118.0a1 (2023-08-18)

Affected versions

• Nightly 118.0a1 (2023-08-18)

Affected platforms

• ALL

Preconditions:
Set the browser.shopping.experience2023.enabled - TRUE
Set the toolkit.shopping.useOHTTP - TRUE

Steps to reproduce

1. Reach about:preferences and turn off feature recommendations.
2. Reach the Amazon https://www.amazon.com/dp/B09B6ZXD2V/ref=sbl_dpx_office-desks_B0B4CYW8FB_0 link
3. Click and Hold the Not Now button from the Onboarding Shopping sidebar.

Expected result

• The Not now button from the Onboarding Shopping sidebar should change its state when Clicked.

Actual result

• The Not now button from the Onboarding Shopping sidebar is missing the Clicked state.

Regression range
Not Applicable

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:rdoghi, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Shane Hughes [:aminomancer]]

Seems like all our secondary buttons (except secondary top) are missing active styles (see about:welcome for example)

Comment 3

[Punam Dahiya [:pdahiya]]

'Not Now' is a link in final Figma designs. This should be fixed with CSS fixes in https://bugzilla.mozilla.org/show_bug.cgi?id=1846763

Comment 4

[Emily McMinn :emcminn]

Attachment: Bug 1849365 - Apply active styles to about:welcome secondary buttons

Comment 5

[Emily McMinn :emcminn]

Attached patch should fix the issue for all multistage messages, including future buttons in the sidebar.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be838735b3cf
Apply active styles to about:welcome secondary buttons r=desktop-theme-reviewers,Itiel

Comment 7

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/be838735b3cf

Comment 8

[Peter Magyari (Desktop QA)]

Verified on Nightly 119.0a1 (2023-09-07) this was fixed by Bug 1846763 ('Not Now' became a link so it no longer has a "clicked/active state")

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emcminn, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox118 to wontfix.

For more information, please visit BugBot documentation.