1849433 - Some drivers handle extremely large draws poorly

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect, P1)

Description

[Kelsey Gilbert [:jgilbert]]

Drivers are not always robust to extremely large draw calls, such as drawing INT32_MAX verts.
Such calls aren't useful in practice, so let's just cap this to something very-but-not-extremely high, like 30M.
Callers would still be able to split the draw call into smaller pieces, which is something we want to encourage anyway so as to not lock up the browser doing a single call.

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1849433 - Add webgl.max-vert-ids-per-draw, default 30M.

Also:

• Prune includes of WebGLContext.h from other headers.

Comment 2

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1849433 - Code cleanups in dom/canvas/WebGL.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9ecfff5e220
Add webgl.max-vert-ids-per-draw, default 30M. r=gfx-reviewers,gw

Comment 4

[Narcis Beleuzu [:NarcisB]]

Backed out for bustages on WebGLTransformFeedback.h

Backout link: https://hg.mozilla.org/integration/autoland/rev/4bc38d4265c6a238b9b03760025e14f04dd4b13f
Log link: https://treeherder.mozilla.org/logviewer?job_id=426788833&repo=autoland&lineNumber=13542

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5dbfb4ba3bf8
Add webgl.max-vert-ids-per-draw, default 30M. r=gfx-reviewers,gw
https://hg.mozilla.org/integration/autoland/rev/de29766d1de7
Code cleanups in dom/canvas/WebGL. r=gfx-reviewers,gw
https://hg.mozilla.org/integration/autoland/rev/6af19cd39b19
apply code formatting via Lando

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/5dbfb4ba3bf8
https://hg.mozilla.org/mozilla-central/rev/de29766d1de7
https://hg.mozilla.org/mozilla-central/rev/6af19cd39b19

Comment 7

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 9349662 [details]
Bug 1849433 - Add webgl.max-vert-ids-per-draw, default 30M.

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: This protects against poor drivers which can sometimes lead to sec issues.
  It's better to be proactive here rather than repeatedly reactive.
• User impact if declined: Occasional long tail of sec issues due to poor drivers.
• Fix Landed on Version: 119
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Not very risky generally, and quite safe if this rides out to Beta without regressions. I don't expect any regressions anyways though.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9349662 [details]
Bug 1849433 - Add webgl.max-vert-ids-per-draw, default 30M.

Approved for 115.4esr.

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/44c386281c90