1849558 - Firefox view navigation list items have the focus ring cut

Status: VERIFIED FIXED

(Firefox :: Firefox View, defect, P3)

Description

[Catalin Sasca, Desktop QA [:csasca]]

Attachment: fx view focus ring .png

Found in

• Firefox 118.0a1

Affected versions

• Firefox 118.0a1

Tested platforms

• Affected platforms: macOS 13.5, Ubuntu 22.04, Windows 10

Preconditions

• browser.tabs.firefox-view-next is set to true

Steps to reproduce

1. Launch Firefox and access Firefox View
2. Tab between the categories on the left side of the page

Expected result

• The focus ring is not cut

Actual result

• The focus ring is cut on both left and right sides

Regression range

• Mozregression points that this was introduced by: Bug 1849195 - Use max-width/height to prevent extra scrollbars. r=dholbert,fxview-reviewers,kcochrane

Additional notes

• The issue can be seen in the attachment

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1849195

:mkaply, since you are the author of the regressor, bug 1849195, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1849195

Comment 3

[Dianna Smith [:diannaS] - on Leave, back on August 9th]

minor issue but keep fx120 affected given that Firefox View will be enabled in 119

Comment 4

[Sarah Clements [:sclements]]

(In reply to Dianna Smith [:diannaS] from comment #3)

minor issue but keep fx120 affected given that Firefox View will be enabled in 119

Hi, is there a reason we want to track this for 120 given that its an S4? Is it because its a regression?

Comment 5

[Dianna Smith [:diannaS] - on Leave, back on August 9th]

We are not tracking per say (that would have a tracking +) , but just marked the status flag as affected so that it continues to show up in our queries. It is a recent minor regression for a feature that is about to be enabled. If you prefer for it to be out of sight, i dont mind either way. :)

Comment 6

[Nikki Sharpley (:nikkis) (she/her)]

Attachment: Bug 1849558 Fix Firefox View navigation focus ring visibility

Removed the overflow property to prevent focus ring from being clipped.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a79628380eb
Fix Firefox View navigation focus ring visibility r=fxview-reviewers,sfoster

Comment 8

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/3a79628380eb

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:nsharpley, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox120 to wontfix.

For more information, please visit BugBot documentation.

Comment 11

[Dana Lucaci, Desktop QA]

Reproduced the issue with Firefox 118.0a1 (2023-08-21) on macOS 12 ARM.
The issue is verified fixed with Firefox 122.0a1 (20231127214936) and Firefox 121.0b4 (20231127091758) on macOS 12 ARM, Ubuntu 22.04 and Win 10.