1849581 - The Star ratings from the Shopping sidebar are not read out loud by the NVDA

Status: VERIFIED FIXED

(Firefox Graveyard :: Shopping, defect, P2)

Description

[Rares Doghi, Desktop QA]

Found in

• Nightly 118.0a1 (2023-08-21)

Affected versions

• Nightly 118.0a1 (2023-08-21)

Affected platforms

• Windows

Preconditions:
Set the browser.shopping.experience2023.enabled - TRUE
Set the browser.shopping.experience2023.optedIn - 1
Enable NVDA.

Steps to reproduce

1. Reach the following links https://www.amazon.com/dp/B07V6ZSHF4?th=1
2. Hover the mouse cursor on top of the Star Ratings of the "Adjusted rating" card and "More to Consider" card.

Expected result

• The Star ratings should be read out loud by NVDA.

Actual result

• The Star ratings are not read out loud by NVDA.

Regression range
Not Applicable

Comment 1

[BugBot [:suhaib / :marco]]

:rdoghi, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[:Gijs (he/him)]

Anna, do you know what is going on here? There's a <div> with a title attribute so I would have expected that to have been read, but it appears that does not work. Perhaps it would need a role of some kind (if so, what would be appropriate)? And/or the title attribute needs mirroring to the moz-five-stars element as an aria-label attribute?

Comment 3

[❌ Anna Yeddi [:ayeddi] ❌ On leave until 2027-01-04]

(In reply to :Gijs (he/him) from comment #2)

Anna, do you know what is going on here? There's a <div> with a title attribute so I would have expected that to have been read, but it appears that does not work. Perhaps it would need a role of some kind (if so, what would be appropriate)? And/or the title attribute needs mirroring to the moz-five-stars element as an aria-label attribute?

Great catch, @Rares! Thank you

@Gijs, you are right, at the moment the moz-five-stars element does not have any role this it’s title is being ignored by the Accessibility API. Adding role=“image" to it fixed both the lack of semantic role and textual alternative issues.

Comment 4

[:Gijs (he/him)]

Given how critical the rating is to the whole shopping experience, I think having it be read out / accessible to AT users is more than an S3.

Comment 5

[❌ Anna Yeddi [:ayeddi] ❌ On leave until 2027-01-04]

Attachment: Bug 1849581 - Add role=image to the moz-five-star wrapper. r=Gijs,hjones

Priving an accessible role to the moz-five-star-rating wrapper to ensure its title/aria-label is not ignored by the Accessibility API and that its value will be announced on hover when a screen reader like NVDA is running too.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/343ca7217983
Add role=image to the moz-five-star wrapper. r=reusable-components-reviewers,shopping-reviewers,Gijs,hjones

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/343ca7217983

Comment 8

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:ayeddi, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox118 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Peter Magyari]

Star-ratings are read by NVDA accordingly, I have verified this using Firefox Nightly 119.0a1 (20230912041249) on Windows 10 x64.