1849641 - Consider logging the reason for the returned network error if the status code cannot be parsed

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[Alfred Peters [:infofrommozilla]]

Attachment: Screenshot 2023-08-21 202355.png

Due to an error in my server, the FF only showed a blank page. There was no message in the log and even in the network console the information was limited to a lapidary NS_ERROR_FAILURE.

A hint on the cause of the error (the broken/missing response code), would be appropriate and extremely helpful.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1687903

:twisniewski, since you are the author of the regressor, bug 1687903, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Thomas Wisniewski [:twisniewski]]

I definitely agree that using a more detailed code here is a good idea, I'll try to get this done before the soft freeze. I think I will add at least one code, NS_ERROR_PARSING_HTTP_STATUS_LINE, for this purpose.

:nchevobbe, if I do this, I assume the networking panel will show that code instead of NS_ERROR_FAILURE?

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

(In reply to Thomas Wisniewski [:twisniewski] from comment #2)

I definitely agree that using a more detailed code here is a good idea, I'll try to get this done before the soft freeze. I think I will add at least one code, NS_ERROR_PARSING_HTTP_STATUS_LINE, for this purpose.

:nchevobbe, if I do this, I assume the networking panel will show that code instead of NS_ERROR_FAILURE?

Not sure, bomsy would know better. He's not accepting ni for now, so let's ask him later this week :)

Comment 4

[Hubert Boma Manilla (:bomsy)]

(In reply to Thomas Wisniewski [:twisniewski] from comment #2)

I definitely agree that using a more detailed code here is a good idea, I'll try to get this done before the soft freeze. I think I will add at least one code, NS_ERROR_PARSING_HTTP_STATUS_LINE, for this purpose.

:nchevobbe, if I do this, I assume the networking panel will show that code instead of NS_ERROR_FAILURE?

Yes that is the correct, it should show the NS_ERROR_PARSING_HTTP_STATUS_LINE instead.

Comment 5

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1849641 - log a console message and use a more descriptive error code when HTTP response status line cannot be parsed; r?valentin

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c187cb4839c0
log a console message and use a more descriptive error code when HTTP response status line cannot be parsed; r=valentin,necko-reviewers

Comment 7

[Cristian Tuns]

Backed out for causing Gtest failures TestHttpResponseHead

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | TestHttpResponseHead.bug1687903 | Expected equality of these values:

Comment 8

[Thomas Wisniewski [:twisniewski]]

Ah, that's a quick fix. I'll push again in a moment.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c341836bd4a7
log a console message and use a more descriptive error code when HTTP response status line cannot be parsed; r=valentin,necko-reviewers

Comment 10

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/c341836bd4a7