1849705 - The "How we determine review quality" label overlaps the Expand arrow button

Status: VERIFIED FIXED

(Firefox :: Shopping, defect, P2)

Description

[Rares Doghi, Desktop QA]

Attachment: HighContrastMac.png

Found in

• Nightly 118.0a1 (2023-08-22)

Affected versions

• Nightly 118.0a1 (2023-08-22)

Affected platforms

• Mac

Preconditions:
Set the browser.shopping.experience2023.enabled - TRUE
Set the browser.shopping.experience2023.optedIn - 1
Enable High Contrast.

Steps to reproduce

1. Reach https://www.amazon.com/dp/B09F56RRF8/ref=vp_d_cpf-substitute-widget_pd?_encoding=UTF8&pf_rd_p=f3e0f858-bc1b-4cf8-bdca-f6e1481f1fbe&pf_rd_r=H70ERT7R4QGKSD4DH14X&pd_rd_wg=QXmZV&pd_rd_i=B09F56RRF8&pd_rd_w=LWAch&content-id=amzn1.sym.f3e0f858-bc1b-4cf8-bdca-f6e1481f1fbe&pd_rd_r=28393c3e-7f14-46bb-878a-82ec1fbb043f

Expected result

• The "How We determine review quality" label should split on a second row when there isnt enough space.

Actual result

• The "How We determine review quality" label looks like it overlaps the Expand button.
  Please note that this is more visible with High contrast enabled, without high contrast the text just looks a bit too close to the Expand button.

Regression range
Not Applicable

Comment 1

[Rares Doghi, Desktop QA]

Attachment: macHow.png

After zooming in it seems that its a pixel away from overlapping, Please close it as invalid if this looks acceptable.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:rdoghi, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 3

[Jonathan Epstein]

Also happening for some not in HCM.

Comment 4

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Marking as P2: it's a highly visible bug and should be an easy fix.

Comment 5

[kpatenio]

Attachment: Bug 1849705 - add additional gap between shopping card label and accordion button to improve display for longer strings

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/284c6c62aab9
add additional gap between shopping card label and accordion button to improve display for longer strings r=shopping-reviewers,Gijs

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/284c6c62aab9

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:kpatenio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox118 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Peter Magyari (Desktop QA)]

I have verified the fix using Firefox Nightly 119.0a1 (20230906091315) on MacOS 11 and MacOS 12, the gap between the label and the accordion button is no longer too small.

Comment 10

[Rares Doghi, Desktop QA]

Updating the remaining flag.