Closed Bug 1849791 Opened 2 years ago Closed 2 years ago

Enable context paint in SVG of moz-anno protocol

Categories

(Firefox :: Address Bar, enhancement)

enhancement

Tracking

()

VERIFIED FIXED
118 Branch
Tracking Status
firefox118 --- verified
firefox119 --- verified

People

(Reporter: daisuke, Assigned: daisuke)

References

Details

Attachments

(1 file)

In bug 1844150, we fixed the favicon url of moz-anno for the local favicon cache. If there is no data in the cache, we fallback the content to the default favicon SVG[1]. Its SVG assumes context paint though, since moz-anno protocol was not covered[2], the icon color was wrong. So, we will make context paint enable for the moz-anno protocol as well.

[1] https://searchfox.org/mozilla-central/rev/6e2fb6cde8ba14b9d9a6367ba61a97ad1f13b1c2/toolkit/components/places/nsAnnoProtocolHandler.cpp#183-187
[2] https://searchfox.org/mozilla-central/rev/98d0035da36d786b7ca9191b8a23de9c2c943465/layout/svg/SVGContextPaint.cpp#65-66

Summary: Enable context properties in SVG of moz-anno protocol → Enable context paint in SVG of moz-anno protocol
Pushed by dakatsuka.birchill@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/57ed97d31556 Enable context paint in SVG of moz-anno protocol r=places-reviewers,dholbert,mak
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 118 Branch

Reproducible on a 2023-08-22 Nightly build on Ubuntu 22.
Verified as fixed on Firefox 118.0b2(20230829180158) and Nightly 119.0a1(20230830042643) on Ubuntu 22, macOS 12, Windows 10.
Favicon now displays the correct color scheme.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: