Closed Bug 1849792 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 41594 - [wptrunner] Honor wptserve `config.json`

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox119 fixed)

Status:
RESOLVED FIXED
Milestone:
119 Branch
Tracking Flags:
Tracking Status
firefox119 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 41594 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/41594
Details from upstream follow.

Jonathan Lee <jonathanjlee@google.com> wrote:

[wptrunner] Honor wptserve config.json

Currently, wpt run populates SSL-related kwargs with defaults that will override any settings in config.json. wpt run should instead prioritize command line options first, explicit config.json values second, and, if both are unavailable, the implicit hardcoded values last.

This change's only breakage risk is if a vendor's CI system:

  1. Does not provide explicit wpt run SSL options
  2. Relies on the implicit hardcoded values, yet
  3. Specifies a config.json with different pregenerated.* values

This change makes progress on https://crbug.com/1467065 in Chromium, which runs WPTs with its own test runner + wpt serve --config. Using wptrunner's TestEnvironment should function the same way.

The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
Test result changes from PR not available.
Test result changes from PR not available.
Test result changes from PR not available.
Test result changes from PR not available.
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/43eadbcded47 [wpt PR 41594] - [wptrunner] Honor wptserve `config.json`, a=testonly

https://hg.mozilla.org/mozilla-central/rev/43eadbcded47

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox119: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 119 Branch
You need to log in before you can comment on or make changes to this bug.