1849810 - [wpt-sync] Sync PR 41595 - Revert "[bfcache] Introduce NotRestoredReasons interface"

Status: RESOLVED FIXED

(Core :: DOM: Performance, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 41595 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/41595
Details from upstream follow.

Yuki Shiino <[e-mail]> wrote:

Revert "[bfcache] Introduce NotRestoredReasons interface"

This reverts commit c5d373e378134b9594f80045f747f5b5b8966402.

Reason for revert: https://crbug.com/1474767

Original change's description:

[bfcache] Introduce NotRestoredReasons interface

This CL introduces NotRestoredReasons interface to make the implementation match the spec draft1.
This also changes NotRestoredReasons attribute's name from blocked to preventedBackForwardCache and its return value, thus changing WPT as well.

Bug: 1472637
Change-Id: I4dcecd5a012c36c883933ed3d04c776bfe844f6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4770594
Reviewed-by: Kentaro Hara \<[e-mail]>
Commit-Queue: Yuzu Saijo \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1185723}

Bug: 1472637
Change-Id: Ie2e4322abd062a4cdff14f9f78c8651c06453ae3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4805368
Bot-Commit: Rubber Stamper \<[e-mail]>
Auto-Submit: Yuki Shiino \<[e-mail]>
Commit-Queue: Yuki Shiino \<[e-mail]>
Reviewed-by: Kentaro Hara \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1187060}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 41595 applied with additional changes from upstream: d4021e194b6a79b59a256ed4efbaab5598bf4185, 489dcfa3de2d1f57c5846b6bb85abdc368404d33

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=6b3c9d456b40b7f08a2602f4ae1f0dad9899bf49

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 9 tests and 1 subtests

Status Summary

Firefox

OK : 9
FAIL : 9

Chrome

OK : 9
PASS : 3
FAIL : 6

Safari

OK : 8
FAIL : 8
TIMEOUT: 2

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /performance-timeline/not-restored-reasons/performance-navigation-timing-attributes.tentative.window.html [wpt.fyi]
  • RemoteContextHelper navigation using BFCache: FAIL (Chrome: FAIL, Safari: FAIL)
• /performance-timeline/not-restored-reasons/performance-navigation-timing-bfcache-reasons-stay.tentative.window.html [wpt.fyi]
  • RemoteContextHelper navigation using BFCache: FAIL (Chrome: FAIL, Safari: FAIL)
• /performance-timeline/not-restored-reasons/performance-navigation-timing-bfcache.tentative.window.html [wpt.fyi]
  • RemoteContextHelper navigation using BFCache: FAIL (Chrome: PASS, Safari: FAIL)
• /performance-timeline/not-restored-reasons/performance-navigation-timing-cross-origin-bfcache.tentative.window.html [wpt.fyi]
  • RemoteContextHelper navigation using BFCache: FAIL (Chrome: PASS, Safari: FAIL)
• /performance-timeline/not-restored-reasons/performance-navigation-timing-not-bfcached.tentative.window.html [wpt.fyi]
  • RemoteContextHelper navigation using BFCache: FAIL (Chrome: FAIL, Safari: FAIL)
• /performance-timeline/not-restored-reasons/performance-navigation-timing-redirect-on-history.tentative.window.html [wpt.fyi]
  • RemoteContextHelper navigation using BFCache: FAIL (Chrome: PASS, Safari: TIMEOUT)
• /performance-timeline/not-restored-reasons/performance-navigation-timing-reload.tentative.window.html [wpt.fyi]
  • RemoteContextHelper navigation using BFCache: FAIL (Chrome: FAIL, Safari: FAIL)
• /performance-timeline/not-restored-reasons/performance-navigation-timing-same-origin-bfcache.tentative.window.html [wpt.fyi]
  • RemoteContextHelper navigation using BFCache: FAIL (Chrome: FAIL, Safari: FAIL)
• /performance-timeline/not-restored-reasons/performance-navigation-timing-same-origin-replace.tentative.window.html [wpt.fyi]
  • RemoteContextHelper navigation using BFCache: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cbd9852b62bc
[wpt PR 41595] - Revert "[bfcache] Introduce NotRestoredReasons interface", a=testonly

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/cbd9852b62bc