1849815 - Firefox Translation proposing French to French translation

Status: RESOLVED FIXED

(Firefox :: Translations, defect)

Description

[Bernard]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/117.0

Steps to reproduce:

If I open a new page in french, Firefox propose to translate it from french to french !
It was only possible to deactivate translation from french to ... by setting the default language of Firefox in another language like English.
It's a new bug, which appeared on Firefox 117.0. I'm on Linux Ubuntu 22.04
I use Firefox in french.

Actual results:

When I open a Web page in french, I get a proposition to translate the page from french into french, which is completely useless.
It took me half an hour to find how to deactivate the proposition to translate from English to French !
I was really angry about this new "feature".
Somebody (lolobrol) reported bug 1842347 which is similar. The page propose to translate from Dutch to Dutch. I don't understand why this Bug report was closed, since it is very annoying. It's a true BUG.

Expected results:

French pages should not be translated into French !
The same should be true for any language, so no translation proposition should appear for translating from one language into the same language !

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Bernard]

I don't think this Bug has anything to do with Gtk. It's a Bug which was added in version 117.0 of Firefox.
I couldn't try this bug on Windows 10, because only the version 116.3 is available on Windows 10.

Comment 3

[Henry Green [:harperG]]

i can reporoduce this on nightly version 118.0a1

Comment 4

[Erik Nordin [:nordzilla]]

I do believe that this is a legitimate defect that I am able to reproduce by removing all web preferred languages in about:preferences.

---

Steps to Reproduce

Note: Results may be affected by your specified operating system langauges. I have only English in mine.
Note: I tested with Spanish instead of French, which should be the same with regard to the logic of the code.

1. Download Spanish Firefox 117 beta (the beta version at the time of writing).

2. Navigate to about:preferences.

3. Navigate to the web preferred languages menu.

"Elegir el idioma preferido para mostrar las páginas web -- Seleccionar..."

4. Remove all languages from the list of web preferred languages.

"Quitar -- Aceptar"

5. Navigate to a Spanish web page, e.g. https://es.wikipedia.org/wiki/Wikipedia:Portada

---

Expected Results

• [✔] Translation is not offered, unless OS-level preferences detect a valid language pair for translating.

Actual Results

• [x] Translation is offered from español to español.

Comment 5

[Greg Tatum [:gregtatum]]

Attachment: Bug 1849815 - Use the app locale when web content languages are empty; r?nordzilla!

Comment 6

[Bernard]

Ignoring this Bug will push people away from Firefox.
Proposing to translate from a language to the same language is a BUG !
I was very upset with this Bug, even that after half an hour I managed to avoid it.
It's not normal that if the browser is in French, one cannot deactivate the proposal to translate French pages !

Comment 7

[Sören Hentzschel]

Ignoring this Bug will push people away from Firefox.

This bug was reported yesterday (!). Eric confirmed it 19 hours ago (!). Greg uploaded a patch 17 hours ago (!). This is very fast! So who exactly is "ignoring this bug"? 😐

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:gregtatum, could you have a look please?

For more information, please visit BugBot documentation.

Comment 9

[Greg Tatum [:gregtatum]]

Attachment: Bug 1849815 - Use the app locale when web content languages are empty (for beta); r?nordzilla!

Copy of D186711, but cherry-picked onto beta

Comment 10

[Greg Tatum [:gregtatum]]

Attachment: Bug 1849815 - Use the app locale when web content languages are empty; r?nordzilla!

This is the patch for D186711 but cherry-picked onto beta

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/966352e81794
Use the app locale when web content languages are empty; r=nordzilla

Comment 12

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/966352e81794

Comment 13

[Greg Tatum [:gregtatum]]

Comment on attachment 9350001 [details]
Bug 1849815 - Use the app locale when web content languages are empty; r?nordzilla!

Beta/Release Uplift Approval Request

• User impact if declined: A user can be bombarded with bad translation offers.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This feels low as it changes some well tested code path, and adds a fairly trivial change for an edge case.
• String changes made/needed:
• Is Android affected?: No

Comment 14

[Pascal Chevrel:pascalc]

Comment on attachment 9350001 [details]
Bug 1849815 - Use the app locale when web content languages are empty; r?nordzilla!

Approved for 118.0b7, thanks.

Comment 15

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/fc03c293bcac

Comment 16

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/fc03c293bcac