184982 - Make PostScript module optional for QT

Status: RESOLVED FIXED

(Core Graveyard :: Ports: Qt, defect)

Description

[timeless]

one of the people on irc.kde.org #qt managed to have their build config not want
postscript. here's the patch. biesi if you would r= then you can check this in.

Comment 1

[timeless]

Attachment: make ps conditional

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 109097 [details] [diff] [review]
make ps conditional

r=biesi, I'll checkin later today

Comment 3

[Roland Mainz]

The patch still misses glue for configure.in...

Comment 4

[Roland Mainz]

References: The same RFE exists for the Xlib toolkit - see bug 185008 ("Make
PostScript module optional for Xlib toolkit") ...

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

hm... I don't think it should be disabled by default for qt...

however, you're raising a good point, the patch misses a Makefile.in change
which is needed.
basically, gfx/src/qt/Makefile.in needs these lines:
186 ifdef MOZ_ENABLE_POSTSCRIPT
187 DEFINES         += -DUSE_POSTSCRIPT
188 endif
189 
190 ifdef MOZ_ENABLE_XPRINT
191 DEFINES         += -DUSE_XPRINT -DUSE_MOZILLA_TYPES
192 EXTRA_DSO_LDOPTS += $(MOZ_XPRINT_LDFLAGS)
193 endif
(copied from gfx/src/gtk/Makefile.in)

timeless: can I have r=timeless on inserting the above changes into the
mentioned Makefile, above the LOCAL_INCLUDES stuff? (in addition to checking in
your patch)

Comment 6

[Roland Mainz]

Christian Biesinger wrote:
> hm... I don't think it should be disabled by default for qt..

Erm... I am going to add both Xprint and |QPrinter| support instead - both are
significantly better than Mozilla's own PostScript module (that would save
~400KB in the final Qt-port distribution tarball... :) ...

Comment 7

[timeless]

biesi: go for it.

gisburn: when we have mozilla working well enough to use for basic stuff and you
get QPrinter support working better than postscript (this should be easy) then
we can change postscript to not be built by default, but until then i think we
should have at least one print module which does stuff, at least so we can see
where to put things.

Comment 8

[Roland Mainz]

timeless wrote:
> when we have mozilla working well enough to use for basic stuff and you
> get QPrinter support working better than postscript (this should be easy) then
> we can change postscript to not be built by default, but until then i think we
> should have at least one print module which does stuff, at least so we can see
> where to put things.

I think we should make that decision at an early stage - and disabling it by
default does not mean it won't disappear completely - people can still use
--enable-postscript to enable it on demand... :)

Comment 9

[Roland Mainz]

s/it won't disappear/it will disappear/

Comment 10

[hacker formerly known as [e-mail]]

There's no reason postscript printing should be disabled based upon toolkit. 
The two are disjoint feature sets.  Supporting building w/o postscript is one
thing, but making it the default doesn't make much sense.  Postscript printing
"just works" on most platforms/configurations whereas xprint requires a special
setup and I'm not sure what QPrinter requires.  In any case, the configure
changes requested for xlib have been WONTFIX'd.

Comment 11

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in, including parts mentioned in comment 5