184993 - Add bookmark sheet does not remember last choosen folder

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, enhancement)

Description

[Stephane Moureau]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.0.1) Gecko/20021210 Chimera/0.6+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.0.1) Gecko/20021210 Chimera/0.6+

Add Bookmark sheet should remember the last choosen folder even if Cancel or OK
has been used.
That will allow to choose a folder, then click Cancel and then add a serie of
bookmarks in the same folder without having to change it all the time.

Reproducible: Sometimes

Steps to Reproduce:
1. Cmd-D to open the Add B. sheet
2. Change the Create in Folder
3. Click on Cancel or OK
4. Cmd-D again

Actual Results:  
Last choosen folder is sometimes forgotten after an OK and always after a Cancel.

Expected Results:  
Keep the last choosen folder with OK and Cancel.

Comment 1

[Simon Fraser [no longer active]]

Yeah

Comment 2

[David Haas (gone, not reading mail)]

Attachment: patch

"Add bookmark" folder uses whatever's selected if the bookmark manager is
visible OR whatever was last selected/used to add bookmarks if the bookmark
manager is not visible.  Only sets folder on "OK", not "Cancel" - that's not
how I think Cancel should work.

Comment 3

[David Haas (gone, not reading mail)]

-> pink

Comment 4

[Mike Pinkerton (not reading bugmail)]

checked in with some additional fixes to make it work when history is selected
when the bookmark sheet comes up and to ensure the selection changes when the
parent is a toplevel collection.