1849998 - Debugger frontend doesn't always assume that 'column' is 0-based

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Alexandre Poirot [:ochameau]]

We have some code here and there that assume that column is 1-based, like line.
But it isn't. line is 1-based, but column is 0-based.

All this is ultimately decided in spidermonkey over there:
https://searchfox.org/mozilla-central/rev/d81e60336d9f498ad3985491dc17c2b77969ade4/js/src/vm/JSScript.h#1544-1547

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1849998 - [devtools] Unify the codebase to interpret location's column to be 0-based.

There was some inconsistancies in column interpretation.
Some code was assuming it was 1-based.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ceb4a53f17f
[devtools] Unify the codebase to interpret location's column to be 0-based. r=devtools-reviewers,nchevobbe

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/4ceb4a53f17f