1850007 - Inspecting an SVG document doesn't load the overlay correctly

Status: VERIFIED FIXED

(DevTools :: Inspector, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

STR:

• Go to https://hg.mozilla.org/mozilla-central/raw-file/tip/browser/components/firefoxview/content/cfr-lightning.svg
• Inspect the <path> element.

ER:

• Overlay shows up.

AR:

• A black rectangle and serif text show up.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1850007 - Make sure that the highlighter styles are loaded. r=#devtools-reviewers

On an SVG document, createElement() returns an null-namespace element.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1824886

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Screenshot of what I see.

I see this in a clean profile too (the regression range was taken with mozregression).

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ff813a820f4
Make sure that the highlighter styles are loaded. r=devtools-reviewers,nchevobbe

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/5ff813a820f4

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox117 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9350150 [details]
Bug 1850007 - Make sure that the highlighter styles are loaded. r=#devtools-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Comment 0
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial fix.
• String changes made/needed: none
• Is Android affected?: Yes

Comment 8

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

I have reproduced this issue using Firefox 118.0a1 (2023.08.24) on Windows 10.
I can confirm this issue is fixed, I verified using Firefox 118.0a1 latest nightly on Windows 10.
Note that the inspect a svg element works only for the first time when accessing the test page, both when reproducing and verifying, see attached screenshots. On macOS and Ubuntu I am not able to inspect the svg image. Maybe this is another known issue?

Comment 9

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

Attachment: first time accessing.png

Comment 10

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

Attachment: reload the page and inspect.png

Comment 11

[Emilio Cobos Álvarez (:emilio)]

I don't seem to be able to reproduce that on linux. In any case, mind filing a separate bug for that? Thanks.

Comment 12

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #11)

I don't seem to be able to reproduce that on linux. In any case, mind filing a separate bug for that? Thanks.
Here is the separate bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1850539

Comment 13

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

I can confirm this issue is fixed, I verified using Firefox 118.0b2 on Windows 10.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9350150 [details]
Bug 1850007 - Make sure that the highlighter styles are loaded. r=#devtools-reviewers

Approved for 117.0.1

Comment 15

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/703358ca368d

Comment 16

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

I can confirm this issue is fixed, I verified using Firefox 117.0.1 on Windows 10.