1850086 - `pointerDown(ButtonType.MIDDLE)` and `pointerDown(ButtonType.RIGHT)` synthesizes wrong `buttons` value

Status: RESOLVED FIXED

(Remote Protocol :: Agent, defect, P3)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sickish, maybe slower respose)]

If you call pointerDown(ButtonType.MIDDLE), you'll see a mousedown event whose buttons value is 2, similarly, pointerDown(ButtonType.RIGHT), you'll see a mousedown whose buttons is 4. However, the values should be swapped.

• https://w3c.github.io/uievents/#dom-mouseevent-buttons
• https://w3c.github.io/pointerevents/#the-buttons-property

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Thanks Masayuki! FYI geckodriver just forwards the WebDriver command to Marionette. So lets get it moved to the right component.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sickish, maybe slower respose)]

Testing... https://treeherder.mozilla.org/jobs?repo=try&revision=0f7eb81bd4a3025924faade9a5baac05404fce63

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sickish, maybe slower respose)]

Attachment: Bug 1850086 - Make `Actions` compute `buttons` value from `button` value correctly

MouseButton.buttons value for middle button is 4, and for right button is
2. However, their button values are 1 and 2. Therefore, their values
cannot be computed with Math.pow simply.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a0cba0c9a320
Make `Actions` compute `buttons` value from `button` value correctly r=webdriver-reviewers,whimboo

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/41796 for changes under testing/web-platform/tests

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/a0cba0c9a320

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot