1850118 - [macOS] HDR videos with default view on Youtube will have colors washed out/low brightness

Status: RESOLVED DUPLICATE of bug 1849680

(Core :: Audio/Video: Playback, defect)

Description

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Found in

• Firefox 118.0a1

Affected versions

• Firefox 117.0
• Firefox 118.0a1

Tested platforms

• Affected platforms: macOS 12.6.8 and macOS 13.5.1
• Unaffected platforms: Windows, Ubuntu

Steps to reproduce

1. Launch Firefox
2. Visit Youtube and access any HDR video (example video)

Expected result

• HDR works as expected in standard video view

Actual result

• HDR video has washed out colors with low brightness in default view. Theatre and Fullscreen will have HDR working as expected

Regression range

• Will see for a regression

Additional notes

• The issue can be seen in the following attachment
• Reproduced the issue on two macbooks pro 2019 16" with Intel and on one macbook pro 14" 2023 with M2 Max

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:csasca, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Andreas Pehrson [:pehrsons]]

There's a test case for vp9 10bit HDR but it's disabled across all Mac machines.

Comment 3

[Brad Werth [:bradwerth]]

Something strange is happening here. I can reproduce the problem on Nightly 119, but not in Release 117. When I try in mozregression with various dates and builds, I can't reproduce it anywhere. In all cases, YouTube reports that it is serving up HDR, which would not be the case if our capability detection (matching video-dynamic-range: high) was not being honored by YouTube.

I'll do some debugging to figure out what format we're actually putting on the screen in the failure case.

Comment 4

[Brad Werth [:bradwerth]]

Huh. NativeLayerCA::AttachExternalImage is no longer being called. That means that this line in WebRender is never being hit for any macOS video. If this was due to some change in WebRender, I should be able to replicate this with mozregression. I'll keep trying to do so. In the meanwhile, Glenn, has anything changed recently with the way we handle external/native surfaces in WebRender?

Comment 5

[Glenn Watson [:gw]]

Not that I'm aware of.

Comment 6

[Brad Werth [:bradwerth]]

Bug 1766343 would ensure that video surfaces that WebRender treated as non-native (for whatever reason) would still be eligible for specialized video surfaces. That is the root cause of the problem noted in comment 4. It does not help explain why some builds of Firefox are taking this path through WebRender. I may pursue Bug 1766343 as a sideways solution to this Bug.

Comment 7

[Brad Werth [:bradwerth]]

This is probably happening because the rounded-corner edges recently added by YouTube are forcing video frames to be composited in WebRender instead of retaining their identity as external surfaces. Bug 1766343 can't solve this. Bug 1850754 is relevant.

Comment 8

[Brad Werth [:bradwerth]]

(In reply to Brad Werth [:bradwerth] from comment #7)

This is probably happening because the rounded-corner edges recently added by YouTube are forcing video frames to be composited in WebRender instead of retaining their identity as external surfaces. Bug 1766343 can't solve this. Bug 1850754 is relevant.

Glenn, what would it take to get WebRender to support clipping of videos while retaining support for their identity as external textures? Is there a Bug open for this issue?

Comment 9

[Glenn Watson [:gw]]

Bug 1849680 is where we'll be tracking the work to allow this.

Comment 10

[Brad Werth [:bradwerth]]

Fixed by Bug 1849680, as this was caused by YouTube's A/B testing of rounded corner overlays on top of video.

Comment 11

[Catalin Sasca, Desktop Test Engineering [:csasca]]

The issue is still happening on Firefox 123.0b8 and Nightly 124.0a1 (2024-02-07) - screencast

Comment 12

[Brad Werth [:bradwerth]]

(In reply to Catalin Sasca, Desktop QA [:csasca] from comment #11)

The issue is still happening on Firefox 123.0b8 and Nightly 124.0a1 (2024-02-07) - screencast

Are you viewing in Dark Mode with Ambient Mode turned on? If so, that's Bug 1872892.

Comment 13

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Yes, it seems that by deactivating ambient mode, colors instantly pop-in in the video. Thanks!