1850197 - Pre-calculate accessor names for symbol properties and WellKnownAtomId properties

Status: RESOLVED WONTFIX

(Core :: JavaScript Engine, task, P3)

Description

[Tooru Fujisawa [:arai]]

When defining accessor properties with symbol name, we generate accessor names with "get " and "set " prefix and atomize it.
we can put it in the permanent atoms to optimize the prototype creation.

this can also be a preparation to also pre-calculate other accessor names.

Comment 1

[Tooru Fujisawa [:arai]]

it's better applying the same optimization for WellKnownAtomId case, after bug 1847677

Comment 2

[Tooru Fujisawa [:arai]]

as pointed out in bug 1850344, we'll need to add many permanent atoms for WebIDL props, and the binary size increase is really problematic here.
storing the accessor name separately from the property name might not be possible, and we may need to dynamically generate the getter/setter names during startup.
if we explicitly associate the property name and accessors in the data structure (instead of having completely separate entries for property name, getter, and setter), the length can also be omitted, but the hash still needs to be stored.

Comment 3

[Tooru Fujisawa [:arai]]

This bug can be closed if bug 1858040 works, given it make the accessor name generated only when the name is accessed, which doesn't happen in practice (except for debugging scenario).

Comment 4

[Tooru Fujisawa [:arai]]

we'll go with bug 1858040.