1850341 - [popover] Improve focus handling in hidepopover

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Comment 1

[zsun]

Attachment: Bug 1850341 - Improve focus handling in hidepopover. r=emilio

[1] Fix the previous handling of checking if focus is within the hierarchy.
[2] Including the condition for escape key to return to previous focus in hidepopover.

The test .ini file shows more faiulures. Actually, Popover button click focus tests have gone
further and should pass when light dismiss func is in. Due to this, corner cases followed
are affected as they are exepcting to start out hidden. These faiulures should all be sorted
once light dismiss func is done.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1850341 - Make popover tests don't shift focus when sending keypress events. r=zsun

This fixes the tests not working properly when our code follows the
spec.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f52abfa68b37
Make popover tests don't shift focus when sending keypress events. r=zsun

Comment 4

[Iulian Moraru]

Backed out for causing wpt failures on popover-top-layer-combinations.html.

• Push with failures

• Failure log

• Backout link

[task 2023-09-21T00:00:49.877Z] 00:00:49     INFO - TEST-START | /eventsource/format-comments.any.worker.html
[task 2023-09-21T00:00:49.914Z] 00:00:49     INFO - Closing window dfd690bc-44cf-45f2-8cb9-6c2395748406
[task 2023-09-21T00:00:50.110Z] 00:00:50     INFO - 
[task 2023-09-21T00:00:50.110Z] 00:00:50     INFO - TEST-PASS | /html/semantics/popovers/popover-top-layer-combinations.html | Popover combination: Popover Dialog 
[task 2023-09-21T00:00:50.111Z] 00:00:50     INFO - TEST-PASS | /html/semantics/popovers/popover-top-layer-combinations.html | Popover combination: Open Non-modal Popover Dialog 
[task 2023-09-21T00:00:50.111Z] 00:00:50     INFO - TEST-UNEXPECTED-FAIL | /html/semantics/popovers/popover-top-layer-combinations.html | Popover combination: Fullscreen Popover - promise_test: Unhandled rejection with value: object "Error: element click intercepted error"
[task 2023-09-21T00:00:50.112Z] 00:00:50     INFO - ..
[task 2023-09-21T00:00:50.112Z] 00:00:50     INFO - TEST-OK | /html/semantics/popovers/popover-top-layer-combinations.html | took 3893ms
[task 2023-09-21T00:00:50.112Z] 00:00:50     INFO - PID 20291 | 1695254450109	Marionette	INFO	Stopped listening on port 33774
[task 2023-09-21T00:00:50.386Z] 00:00:50     INFO - .
[task 2023-09-21T00:00:50.388Z] 00:00:50     INFO - TEST-OK | /eventsource/format-comments.any.worker.html | took 509ms
[task 2023-09-21T00:00:50.390Z] 00:00:50     INFO - TEST-START | /eventsource/format-data-before-final-empty-line.any.html

Comment 5

[zsun]

@emilio, test /html/semantics/popovers/popover-top-layer-combinations.html fails only for Linux. See https://bugzilla.mozilla.org/show_bug.cgi?id=1838636. I haven't managed to figure out why yet.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e98350675c5a
Make popover tests don't shift focus when sending keypress events. r=zsun

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/e98350675c5a

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/42150 for changes under testing/web-platform/tests

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 10

[zsun]

Attachment: Bug 1850341 - Check if a dialog is opened as a popover in ESC key handling. r=emilio

https://github.com/whatwg/html/pull/9121

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c2ed68b21eb
Improve focus handling in hidepopover. r=emilio

Comment 12

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/8c2ed68b21eb

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/82960246f224
Check if a dialog is opened as a popover in ESC key handling.  r=emilio

Comment 14

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/82960246f224