1850342 - Remove :-moz-loading, and avoid exposing :-moz-broken pseudo-class to content.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task)

Description

[Emilio Cobos Álvarez (:emilio)]

It's unused and untested.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1850342 - Remove non-standard, un-tested :-moz-loading pseudo-class. r=jfkthame

This is technically web-exposed, but if we needed to introduce it for
compat we could always re-introduce it matching false.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1850342 - Do not expose :-moz-broken to content. r=#layout,#style

This is not standard, and we don't use it internally (some chrome
stylesheets use it tho).

In the past this pseudo-class was more useful because it matched the
state for which <img> elements used an inline, but that's no longer
true, see bug 1196668 and co.

Depends on D186938

Comment 3

[Sebastian Zartner [:sebo]]

This removal should be reflected in the browser compat data.

Sebastian

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f14569b8319b
Remove non-standard, un-tested :-moz-loading pseudo-class. r=layout-reviewers,jfkthame

Comment 5

[Cosmin Sabou [:CosminS]]

Backed out for causing dt failures on browser_rules_inactive_css_visited.js

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel&revision=f14569b8319bc5aa44aea8316dd28d3acfc18b85&selectedTaskRun=f6L9h3TFSR6yddprNc9Huw.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=427396448&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/d5c6b564859a28e201a6feec933695d84c05d138

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f0edb489e577
Remove non-standard, un-tested :-moz-loading pseudo-class. r=layout-reviewers,jfkthame

Comment 7

[Iulian Moraru]

Backed out for causing dt failures on browser_rules_inactive_css_visited.js.

• Push with failures

• Failure log

• Backout link

[task 2023-08-29T21:50:38.569Z] 21:50:38     INFO - TEST-START | devtools/client/inspector/rules/test/browser_rules_inactive_css_visited.js
[task 2023-08-29T21:50:39.933Z] 21:50:39     INFO - GECKO(7116) | console.log: "[DISPATCH] action type:" "CLEAR_FLEXBOX"
[task 2023-08-29T21:50:39.934Z] 21:50:39     INFO - GECKO(7116) | console.log: "[DISPATCH] action type:" "UPDATE_GRIDS"
[task 2023-08-29T21:50:40.007Z] 21:50:40     INFO - TEST-INFO | started process screentopng
[task 2023-08-29T21:50:40.271Z] 21:50:40     INFO - TEST-INFO | screentopng: exit 0
[task 2023-08-29T21:50:40.271Z] 21:50:40     INFO - Buffered messages logged at 21:50:38
[task 2023-08-29T21:50:40.271Z] 21:50:40     INFO - Entering test bound 
[task 2023-08-29T21:50:40.271Z] 21:50:40     INFO - Open a url which has visited links
[task 2023-08-29T21:50:40.272Z] 21:50:40     INFO - Adding a new tab with URL: http://example.com/browser/devtools/client/inspector/rules/test/doc_visited.html
[task 2023-08-29T21:50:40.273Z] 21:50:40     INFO - Buffered messages logged at 21:50:39
[task 2023-08-29T21:50:40.273Z] 21:50:40     INFO - Tab added and finished loading
[task 2023-08-29T21:50:40.279Z] 21:50:40     INFO - Wait until the visited links are available
[task 2023-08-29T21:50:40.280Z] 21:50:40     INFO - Open the inspector
[task 2023-08-29T21:50:40.282Z] 21:50:40     INFO - Opening the inspector
[task 2023-08-29T21:50:40.283Z] 21:50:40     INFO - Opening the toolbox
[task 2023-08-29T21:50:40.284Z] 21:50:40     INFO - Console message: [JavaScript Error: "Content-Security-Policy: The page’s settings blocked the loading of a resource at inline (“default-src”)." {file: "chrome://global/content/customElements.js" line: 499 column: 24 source: "display: none !important"}]
[task 2023-08-29T21:50:40.287Z] 21:50:40     INFO - Console message: [JavaScript Error: "Content-Security-Policy: The page’s settings blocked the loading of a resource at inline (“default-src”)." {file: "chrome://global/content/customElements.js" line: 499}]
<...>
[task 2023-08-29T21:50:40.329Z] 21:50:40     INFO - Console message: [JavaScript Error: "Content-Security-Policy: The page’s settings blocked the loading of a resource at inline (“default-src”)." {file: "chrome://global/content/elements/panel.js" line: 62}]
[task 2023-08-29T21:50:40.335Z] 21:50:40     INFO - Toolbox opened and focused
[task 2023-08-29T21:50:40.337Z] 21:50:40     INFO - Selecting the node for '#visited'
[task 2023-08-29T21:50:40.340Z] 21:50:40     INFO - Console message: [JavaScript Warning: "Use of nsIFile in content process is deprecated." {file: "resource://gre/modules/NetUtil.sys.mjs" line: 249}]
[task 2023-08-29T21:50:40.341Z] 21:50:40     INFO - Buffered messages logged at 21:50:40
[task 2023-08-29T21:50:40.347Z] 21:50:40     INFO - Checking whether declarations are marked as used.
[task 2023-08-29T21:50:40.349Z] 21:50:40     INFO - Buffered messages finished
[task 2023-08-29T21:50:40.351Z] 21:50:40     INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/rules/test/browser_rules_inactive_css_visited.js | Uncaught exception in test bound  - at chrome://mochitests/content/browser/devtools/client/inspector/rules/test/head.js:1002 - TypeError: declarations.get(...) is undefined
[task 2023-08-29T21:50:40.352Z] 21:50:40     INFO - Stack trace:
[task 2023-08-29T21:50:40.352Z] 21:50:40     INFO - checkDeclarationIsActive@chrome://mochitests/content/browser/devtools/client/inspector/rules/test/head.js:1002:42
[task 2023-08-29T21:50:40.353Z] 21:50:40     INFO - async*runInactiveCSSTests@chrome://mochitests/content/browser/devtools/client/inspector/rules/test/head.js:1191:17
[task 2023-08-29T21:50:40.354Z] 21:50:40     INFO - async*@chrome://mochitests/content/browser/devtools/client/inspector/rules/test/browser_rules_inactive_css_visited.js:66:9
[task 2023-08-29T21:50:40.354Z] 21:50:40     INFO - async*handleTask@chrome://mochikit/content/browser-test.js:1131:26
[task 2023-08-29T21:50:40.355Z] 21:50:40     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1203:18
[task 2023-08-29T21:50:40.356Z] 21:50:40     INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:1345:14
[task 2023-08-29T21:50:40.357Z] 21:50:40     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1120:14
[task 2023-08-29T21:50:40.357Z] 21:50:40     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1056:13
[task 2023-08-29T21:50:40.358Z] 21:50:40     INFO - Leaving test bound 
[task 2023-08-29T21:50:40.364Z] 21:50:40     INFO - GECKO(7116) | console.log: "[DISPATCH] action type:" "UPDATE_OFFSET_PARENT"
[task 2023-08-29T21:50:40.366Z] 21:50:40     INFO - GECKO(7116) | console.log: "[DISPATCH] action type:" "UPDATE_LAYOUT"
[task 2023-08-29T21:50:40.367Z] 21:50:40     INFO - Console message: [JavaScript Error: "Content-Security-Policy: The page’s settings blocked the loading of a resource at inline (“default-src”)." {file: "chrome://global/content/customElements.js" line: 499 column: 24 source: "display: none !important"}]
[task 2023-08-29T21:50:40.368Z] 21:50:40     INFO - Console message: [JavaScript Error: "Content-Security-Policy: The page’s settings blocked the loading of a resource at inline (“default-src”)." {file: "chrome://global/content/customElements.js" line: 499}]
[task 2023-08-29T21:50:40.370Z] 21:50:40     INFO - Console message: [JavaScript Error: "Content-Security-Policy: The page’s settings blocked the loading of a resource at inline (“default-src”)." {file: "chrome://global/content/elements/panel.js" line: 62}]
[task 2023-08-29T21:50:40.438Z] 21:50:40     INFO - Removing tab.
[task 2023-08-29T21:50:40.440Z] 21:50:40     INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2023-08-29T21:50:40.456Z] 21:50:40     INFO - Got event: 'TabClose' on [object XULElement].
[task 2023-08-29T21:50:40.473Z] 21:50:40     INFO - Tab removed and finished closing
[task 2023-08-29T21:50:40.501Z] 21:50:40     INFO - GECKO(7116) | JavaScript error: , line 0: NotFoundError: No such JSWindowActor 'DevToolsFrame'
[task 2023-08-29T21:50:40.506Z] 21:50:40     INFO - GECKO(7116) | JavaScript error: , line 0: NotFoundError: No such JSWindowActor 'DevToolsFrame'
[task 2023-08-29T21:50:40.510Z] 21:50:40     INFO - GECKO(7116) | JavaScript error: , line 0: NotFoundError: No such JSWindowActor 'DevToolsFrame'
[task 2023-08-29T21:50:40.526Z] 21:50:40     INFO - Console message: [JavaScript Error: "NotFoundError: No such JSWindowActor 'DevToolsFrame'"]
[task 2023-08-29T21:50:40.528Z] 21:50:40     INFO - Console message: [JavaScript Error: "NotFoundError: No such JSWindowActor 'DevToolsFrame'"]
[task 2023-08-29T21:50:40.528Z] 21:50:40     INFO - Console message: [JavaScript Error: "NotFoundError: No such JSWindowActor 'DevToolsFrame'"]
[task 2023-08-29T21:50:40.530Z] 21:50:40     INFO - TEST-PASS | devtools/client/inspector/rules/test/browser_rules_inactive_css_visited.js | The main process DevToolsServer has no pending connection when the test ends - 
[task 2023-08-29T21:50:40.862Z] 21:50:40     INFO - GECKO(7116) | MEMORY STAT | vsize 12336MB | residentFast 877MB | heapAllocated 568MB
[task 2023-08-29T21:50:40.863Z] 21:50:40     INFO - TEST-OK | devtools/client/inspector/rules/test/browser_rules_inactive_css_visited.js | took 2293ms
[task 2023-08-29T21:50:40.878Z] 21:50:40     INFO - checking window state
[task 2023-08-29T21:50:40.903Z] 21:50:40     INFO - TEST-START | devtools/client/inspector/rules/test/browser_rules_inactive_css_xul.js

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6859af9e5f4f
Remove non-standard, un-tested :-moz-loading pseudo-class. r=layout-reviewers,jfkthame

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b272e14e402
Do not expose :-moz-broken to content. r=boris

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b8a556b66a68
Annotate some failures when using reftest-snapshot.

Comment 11

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/6859af9e5f4f
https://hg.mozilla.org/mozilla-central/rev/1b272e14e402
https://hg.mozilla.org/mozilla-central/rev/b8a556b66a68

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:emilio, maybe it's time to close this bug?
For more information, please visit BugBot documentation.