1850351 - Recording value set on extensions.webextensions.remote pref and WebExtensionPolicy.useRemoteWebExtensions attribute as Glean metrics

Status: RESOLVED FIXED

(GeckoView :: Extensions, task, P2)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

While the presence of the Extension child process can be deduced from the extensions.process_event Glean metric "created" label, we are considering recording the value set on the pref controlling the extension child process support and the value of the WebExtensionPolicy.useRemoteWebExtensions attribute to more easily confirm GeckoView instances where the extension child process support has been turned on but not yet effective until the gecko runtime is actually restarted (e.g. when opting in or opting out at runtime, like when enabling/disabling the pref through about:config, nimbus etc.).

Comment 1

[Tomislav Jovanovic :zombie]

Attachment: bug_1850351_request_remote_extensions.md

Comment 2

[Roger Yang [:royang]]

Comment on attachment 9350902 [details]
bug_1850351_request_remote_extensions.md

DATA COLLECTION REVIEW RESPONSE:

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, through the metrics.yaml file and the Glean Dictionary.

2. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

3. If the request is for permanent data collection, is there someone who will monitor the data over time?

[e-mail] will be responsible for monitoring the data over time

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical data

5. Is the data collection request for default-on or default-off?

Default on for all channels.

6. Does the instrumentation include the addition of any new identifiers?

No

7. Is the data collection covered by the existing Firefox privacy notice?

Yes

8. Does the data collection use a third-party collection tool?

No

Result: data-review+

Comment 3

[Tomislav Jovanovic :zombie]

Attachment: Bug 1850351 - Add telemetry for remote extensions pref and runtime value, r?willdurand

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a1d4cb90575f
Add telemetry for remote extensions pref and runtime value, r=willdurand

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/a1d4cb90575f

Comment 6

[William Durand [:willdurand]]

Comment on attachment 9350968 [details]
Bug 1850351 - Add telemetry for remote extensions pref and runtime value, r?willdurand

Beta/Release Uplift Approval Request

• User impact if declined: None, but that'd be very useful to us for debugging purposes.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's low risk because this patch "only" allows us to record the values of a pref and runtime value to ease debugging.
• String changes made/needed:
• Is Android affected?: Yes

Comment 7

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/0273e5fdcb44

Comment 8

[Donal Meehan [:dmeehan]]

Comment on attachment 9350968 [details]
Bug 1850351 - Add telemetry for remote extensions pref and runtime value, r?willdurand

Approved for 118.0b4