1850353 - change download API code_filename to code_file

Status: RESOLVED FIXED

(Tecken :: General, task, P2)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

In bug #1746940, we discovered the Tecken download API has a code_filename query string param, but we implemented use of it as code_file in the stackwalker:

https://github.com/rust-minidump/rust-minidump/blob/7cda551f9f082f8ba5a286f931b5ad24e34861d9/breakpad-symbols/src/http.rs#L210-L211

I think the code_id and code_filename querystring params are Mozilla enhancements and nothing else other than the stackwalker uses them. If that's true, then we can change code_filename to code_file.

This bug covers verifying that and doing it.

We should also add notes to the documentation about how these parameters are Mozilla enhancements.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Gabriele points out this is documented wrong in the Tecken download API docs. The query string param is code_file.

I'll fix the docs.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 2779: bug 1850353: fix download API docs re code_file

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #2779: "bug 1850353: fix download API docs re code_file" in 8a40b18.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

I pushed this to prod just now with bug #1851888. Marking as FIXED.