1850356 - Use long timeouts for WebGPU CTS tests

Status: RESOLVED FIXED

(Core :: Graphics: WebGPU, task, P1)

Description

[Erich Gubler [:ErichDonGubler] (he/him)]

:ErichDonGubler discovered that <meta name="timeout" content="long"> can be used for extend WPT's default timeout from 10 seconds to 60 seconds. This would likely let many more tests with large sets of subtests to finish (rather than timing out, as they currently do). This could cause truly hung tests to eat more time allocated for individual WPT runs (and maybe even cause the whole run to time out), but we're not sure. The scope of this bug is to:

1. Do some experimental Try runs that add <meta name="timeout" content="long"> to each CTS chunk (i.e., testing/web-platform/mozilla/tests/webgpu/chunked/*/cts.https.html) generated by dom/webgpu/tests/cts/vendor.
2. If the above looks promising for CTS health, patch and land changes. File a follow-up bug to limit the scope of long timeouts only to tests that need them, after bug 1822630 is done.

Comment 1

[Erich Gubler [:ErichDonGubler] (he/him)]

Attachment: Bug 1850356: chore(webgpu): use fmt. shorthand, now that our MSRV is > 1.58.0 r=#webgpu-reviewers

Comment 2

[Erich Gubler [:ErichDonGubler] (he/him)]

Attachment: Bug 1850356: test(webgpu): use long timeouts for CTS tests in WPT r=#webgpu-reviewers

Depends on D186991

Comment 3

[Erich Gubler [:ErichDonGubler] (he/him)]

Attachment: Bug 1850356: test(webgpu): accept `PASS`es for `single_buffer:{rw,ww}:* observed to pass r=#webgpu-reviewers

Comment 4

[Erich Gubler [:ErichDonGubler] (he/him)]

Attachment: Bug 1850356: test(webgpu): accept `TIMEOUT`s for `webgpu:api,validation,render_pass,render_pass_descriptor:resolveTarget,different_format:*` r=#webgpu-reviewers

Depends on D187008

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dff3adea4278
test(webgpu): accept `PASS`es for `single_buffer:{rw,ww}:* observed to pass r=webgpu-reviewers,teoxoy
https://hg.mozilla.org/integration/autoland/rev/54aa6bd72897
test(webgpu): accept `TIMEOUT`s for `webgpu:api,validation,render_pass,render_pass_descriptor:resolveTarget,different_format:*` r=webgpu-reviewers,teoxoy
https://hg.mozilla.org/integration/autoland/rev/f2dc88fa4fe2
chore(webgpu): use fmt. shorthand, now that our MSRV is > 1.58.0 r=webgpu-reviewers,teoxoy
https://hg.mozilla.org/integration/autoland/rev/75f28f459fdd
test(webgpu): use long timeouts for CTS tests in WPT r=webgpu-reviewers,teoxoy

Comment 6

[Erich Gubler [:ErichDonGubler] (he/him)]

Fully green Try run with attached changes: https://treeherder.mozilla.org/jobs?repo=try&revision=04c1215677ab00773b5ba73acec79e313a822e94

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/dff3adea4278
https://hg.mozilla.org/mozilla-central/rev/54aa6bd72897
https://hg.mozilla.org/mozilla-central/rev/f2dc88fa4fe2
https://hg.mozilla.org/mozilla-central/rev/75f28f459fdd