1850480 - fenix crashes - the menu freezes

Status: VERIFIED FIXED

(Firefox for Android :: Homepage, defect)

Description

[eclaudiu64]

Attachment: mobizen_20230829_100105.mp4

User Agent: Mozilla/5.0 (Android 11; Mobile; rv:109.0) Gecko/118.0 Firefox/118.0

Steps to reproduce:

1. I entered "Settings".
2. I went to "About Firefox".
3. I quickly hit the back button to exit the main page.
4. You may notice that the application crashes, cannot select the tab tray, cannot enter "Settings", etc.
   It can also be reproduced on Firefox Nightly, Beta and Stable.

Actual results:

The application crashes, stops responding to commands.

Expected results:

The application should not crash and the buttons should work normally.

Comment 1

[Donal Meehan [:dmeehan]]

:twhite tracking this across versions, have you confirmed the crash or have any idea of the regressor?

Comment 2

[Mihai Adrian Carare [:mcarare]]

Looked into this and it can be reproduced. It looks like the regressor is the actual Navigation update from 2.5.3 to 2.6.0.

This can be reproduced by navigating to any sub-page of settings and then quickly pressing back 2 times to get to the browser fragment. At that point, the nav controller still has the settings fragment as a current destination, which is why navigating is not possible.

A simple workaround is to not quickly press the back button, or navigate to home after the navigation is broken, and continue using the app normally. Also, this does not crash and the app does not freeze in fact. Due to these reasons, I would suggest lowering the severity of this bug.

I have linked a Google IssueTracker with a similar STR ( wrong current destination after pressing back)

Comment 3

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1850480 - Revert "Upgrade navigation to latest version" (#3417)

Comment 4

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1850480 - Revert "Upgrade navigation to latest version" (backport #3417) (#3419)

Comment 5

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1850480 - Revert "Upgrade navigation to latest version" (backport #3417) (#3418)

Comment 6

[twhite]

Comment on attachment 9350710 [details] [review]
[mozilla-mobile/firefox-android] Bug 1850480 - Revert "Upgrade navigation to latest version" (backport #3417) (#3418)

Beta/Release Uplift Approval Request

• User impact if declined: Navigation of the application from Settings will not work as expected
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Follow procedure in bug details
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Reverting to the previously used navigation version
• String changes made/needed:
• Is Android affected?: No

Comment 7

[twhite]

Comment on attachment 9350706 [details] [review]
[mozilla-mobile/firefox-android] Bug 1850480 - Revert "Upgrade navigation to latest version" (backport #3417) (#3419)

Beta/Release Uplift Approval Request

• User impact if declined: Navigation of the application from Settings will not work as expected
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Follow procedure in bug details
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Reverting to the previously used navigation version
• String changes made/needed:
• Is Android affected?: No

Comment 8

[Donal Meehan [:dmeehan]]

Comment on attachment 9350706 [details] [review]
[mozilla-mobile/firefox-android] Bug 1850480 - Revert "Upgrade navigation to latest version" (backport #3417) (#3419)

Approved for Fenix 118.0b2

Comment 9

[twhite]

Thank you for reporting this :eclaudiu64!

Comment 10

[eclaudiu64]

(In reply to twhite from comment #9)

Thank you for reporting this :eclaudiu64!

With pleasure !

Comment 11

[Lorand Janos]

Managed to reproduce the issue on an earlier Nightly build (118.0a1) and the current RC 117.0.

Verified as fixed on the current Nightly build (119.0a1 from 2023-08-30) and on the current Beta build (118.0b2).

Devices used:

• Google Pixel 7 (Android 14)
• Redmi 9C NFC (Android 10)

Marking the ticket as verified for 118 and 119.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9350710 [details] [review]
[mozilla-mobile/firefox-android] Bug 1850480 - Revert "Upgrade navigation to latest version" (backport #3417) (#3418)

Approved for 117.0.1.

Comment 13

[Lorand Janos]

Verified as fixed on the latest RC build (117.0.1).

Devices used:

• Google Pixel 7 (Android 14).
• Xiaomi Pad5 (Android 13).
• Lenovo tablet M10 (Android 10).
• Samsung Galaxy Tab A6 (Android 5.1).

Marking the ticket as verified for 117 as well.