1850493 - When ETP is turned OFF, tapping on the lock icon displays the panel without the ETP details

Status: VERIFIED FIXED

(Firefox for Android :: Privacy, defect)

Description

[Mira Lobontiu (Android QA)]

Attachment: double line.png

Steps to reproduce

1. Go to Settings - Privacy and Security - Enhanced Tracking Protection and switch OFF the toggle.
2. Load a page, and tap on the lock icon from the toolbar.
3. Observe the panel.

Expected behavior

The panel displayes the name of the page, the connection status, the tracking protection OFF status, and the "Clear cookies and site data" option.

Actual behavior

The panel displays a double line between the connection status, and the "Clear cookies and site data" option. The ETP OFF status is not displayed at all.

Device information

• Firefox version: Nightly 119.0a1 from 8/29, Beta 118.0b1, RC 117.0
• Android devices: all

Any additional information?

• reproducible with the toolbar set up/down,
• reproducible also on Nightly 111.0a1,
• NOT reproducible when a single page has the ETP turned OFF

Comment 1

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1850493 - The tracking protection divider should be gone if all the views are gone. (#3432)

Comment 2

[BMO Github Automation]

Authored by https://github.com/iorgamgabriel
https://github.com/mozilla-mobile/firefox-android/commit/2bbc8df977ba0cca3fb1be08a94c5b643ca6c556
[main] Bug 1850493 - The tracking protection divider should be gone if all the views are gone.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:giorga, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox118 to wontfix.

For more information, please visit BugBot documentation.

Comment 4

[Lorand Janos]

Managed to reproduce on the latest RC 117.0.1, latest Beta (118.0b5) and earlier Nightly builds.
Verified as fixed on the latest Nightly build (119.0a1 from 2023-09-08).
Device used: Google Pixel 7 (Android 14).
Marking the ticket as verified.

Comment 5

[Lorand Janos]

Attachment: Nightly 2023-09-08.png