Closed
Bug 1850569
Opened 1 year ago
Closed 1 year ago
Remove extra initialisation code inserted by -ftrivial-auto-var-init in mozilla::PrintfTarget::fill_n
Categories
(Firefox Build System :: General, task)
Firefox Build System
General
Tracking
(firefox119 fixed)
RESOLVED
FIXED
119 Branch
| Tracking | Status | |
|---|---|---|
| firefox119 | --- | fixed |
People
(Reporter: sergesanspaille, Assigned: sergesanspaille)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
The function shows up in the trivial-auto-var-init hot paths and there's an extra initialization for the sign variable that the compiler fails to remove. We should be able to help it a bit.
|
Assignee | |
Comment 1•1 year ago
|
||
By coupling the state of signwidth and sign, we provide enough
information to the compiler for it to get rid of an extra mov as a
result of -ftrivial-auto-var-init.
Pushed by sguelton@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/418a22efbc2c
Make it easier for the compiler to analyze mozilla::PrintfTarget::fill_n r=emilio
|
||
Comment 3•1 year ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox119:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 119 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•