1850626 - 1.6x slower than Chrome at setting .style.display

Status: ASSIGNED

(Core :: CSS Parsing and Computation, task)

Description

[Markus Stange [:mstange]]

Attachment: set-style-display-microbenchmark.html

On the attached testcase, I get the following scores:
Firefox: 340ms (Update: 285ms after bug 1851649)
Chrome: 210ms
Safari: 316ms

Matching Chrome's performance would improve Firefox's sp3 score by 0.2%. (This is equivalent to improving a single subtest by 4.1%.)

Comment 1

[Markus Stange [:mstange]]

On Windows, the ratio is closer to 1.15x.
Firefox: 554ms https://share.firefox.dev/47VIDYg 12006 samples
Chrome: 482ms https://share.firefox.dev/3sx0dSf 10311 samples

Comment 2

[Thorin [:thorin]]

On Windows 11 I get closer to 1.4x
Firefox nightly: 456
Chrome stable: 321

Comment 3

[Markus Stange [:mstange]]

(In reply to Markus Stange [:mstange] from comment #1)

Firefox: 554ms https://share.firefox.dev/47VIDYg 12006 samples

This was a profile of the reduced testcase.

Here's a profile from Speedometer 3: https://share.firefox.dev/3P2r0xm

It looks quite a bit different.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1850626 - Simplify and speed-up display parsing. r=#style,#layout,mstange

This avoids uselessly rewinding the parser for single-keyword display
values, and generally makes the code easier to follow.

Comment 5

[Phabricator Automation]

Comment on attachment 9351539 [details]
Bug 1850626 - Simplify and speed-up display parsing. r=#style,#layout,mstange

Revision D187431 was moved to bug 1851649. Setting attachment 9351539 [details] to obsolete.

Comment 6

[Markus Stange [:mstange]]

Update profile from TodoMVC-WebComponents: https://share.firefox.dev/3Zd9V8E (1.7x of Chrome)