1850755 - Enable Well-Formed-Unicode-Strings by default

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Well-Formed-Unicode-Strings is in TC39 stage 4 and has already been merged into ECMA262 spec,
https://github.com/tc39/ecma262/pull/3039

Given it's a small feature, I'll enable it in the nightly build.

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1850755 - Part 1: Turn on well-formed-unicode-strings by default in Browser and JS Shell.

Well-Formed Unicode strings is in TC39 Stage 4 and has been merged into
ECMA262 spec,
https://github.com/tc39/ecma262/pull/3039

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1850755 - Part 2: Update test262-update.py and test262 tests.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a2d5b721e236
Turn on well-formed-unicode-strings by default in Browser and JS Shell. r=spidermonkey-reviewers,jandem
https://hg.mozilla.org/integration/autoland/rev/cd202b5a63ea
Part 2: Update test262-update.py and test262 tests. r=spidermonkey-reviewers,dminor
https://hg.mozilla.org/integration/autoland/rev/6c632ec74ee0
apply code formatting via Lando

Comment 4

[Atila Butkovits]

Backed out for causing SM bustages complaing about xulRuntime.shell.

Backout link: https://hg.mozilla.org/integration/autoland/rev/706735b5079fd2f211cc695aa7bf4b8be083efc8

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=6c632ec74ee0620297a415e539270bcc50332cf4&selectedTaskRun=O17LeyQCSkm0DTN9QZFqFQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=428242659&repo=autoland&lineNumber=57610

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

oh, I didn't update js/src/tests/non262/String/well-formed.js

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1850755 - Part 3: Remove shell options --enable-well-formed-unicode-strings in js/src/tests/non262/String/well-formed.js.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5a0171dba079
Part 1: Turn on well-formed-unicode-strings by default in Browser and JS Shell. r=spidermonkey-reviewers,jandem
https://hg.mozilla.org/integration/autoland/rev/a69e473af87e
Part 2: Update test262-update.py and test262 tests. r=spidermonkey-reviewers,dminor
https://hg.mozilla.org/integration/autoland/rev/40e6ebb21fef
Part 3: Remove shell options in js/src/tests/non262/String/well-formed.js. r=spidermonkey-reviewers,jandem

Comment 8

[Iulian Moraru]

Backed out for causing jsreftest failures on well-formed.js.

• Push with failures

• Failure log

• Backout link

[task 2023-09-08T09:40:01.664Z] 09:40:01     INFO - REFTEST TEST-START | js/src/tests/non262/String/well-formed.js
[task 2023-09-08T09:40:01.665Z] 09:40:01     INFO - REFTEST TEST-LOAD | file:///opt/worker/tasks/task_169416541256914/build/tests/jsreftest/tests/js/src/tests/jsreftest.html?test=non262/String/well-formed.js | 1396 / 16174 (8%)
[task 2023-09-08T09:40:01.684Z] 09:40:01     INFO - TEST-INFO |  FAILED!  ReferenceError: representativeStringArray is not defined
[task 2023-09-08T09:40:01.684Z] 09:40:01     INFO - JavaScript error: file:///opt/worker/tasks/task_169416541256914/build/tests/jsreftest/tests/js/src/tests/non262/String/well-formed.js, line 69: ReferenceError: representativeStringArray is not defined
[task 2023-09-08T09:40:01.695Z] 09:40:01     INFO - REFTEST TEST-UNEXPECTED-FAIL | js/src/tests/non262/String/well-formed.js | Unknown file:///opt/worker/tasks/task_169416541256914/build/tests/jsreftest/tests/js/src/tests/non262/String/well-formed.js:69: ReferenceError: representativeStringArray is not defined item 1
[task 2023-09-08T09:40:01.695Z] 09:40:01     INFO - REFTEST INFO | Saved log: START file:///opt/worker/tasks/task_169416541256914/build/tests/jsreftest/tests/js/src/tests/jsreftest.html?test=non262/String/well-formed.js
[task 2023-09-08T09:40:01.696Z] 09:40:01     INFO - REFTEST INFO | Saved log: [CONTENT] OnDocumentLoad triggering AfterOnLoadScripts
[task 2023-09-08T09:40:01.696Z] 09:40:01     INFO - REFTEST INFO | Saved log: Initializing canvas snapshot
[task 2023-09-08T09:40:01.696Z] 09:40:01     INFO - REFTEST INFO | Saved log: [CONTENT] AfterOnLoadScripts belatedly entering WaitForTestEnd
[task 2023-09-08T09:40:01.696Z] 09:40:01     INFO - REFTEST INFO | Saved log: [CONTENT] WaitForTestEnd: Adding listeners
[task 2023-09-08T09:40:01.697Z] 09:40:01     INFO - REFTEST INFO | Saved log: Initializing canvas snapshot
[task 2023-09-08T09:40:01.697Z] 09:40:01     INFO - REFTEST INFO | Saved log: [CONTENT] MakeProgress
[task 2023-09-08T09:40:01.697Z] 09:40:01     INFO - REFTEST INFO | Saved log: [CONTENT] MakeProgress: STATE_WAITING_TO_FIRE_INVALIDATE_EVENT
[task 2023-09-08T09:40:01.697Z] 09:40:01     INFO - REFTEST INFO | Saved log: [CONTENT] MakeProgress: dispatching MozReftestInvalidate
[task 2023-09-08T09:40:01.698Z] 09:40:01     INFO - REFTEST INFO | Saved log: [CONTENT] MakeProgress
[task 2023-09-08T09:40:01.698Z] 09:40:01     INFO - REFTEST INFO | Saved log: [CONTENT] MakeProgress: STATE_WAITING_FOR_REFTEST_WAIT_REMOVAL
[task 2023-09-08T09:40:01.698Z] 09:40:01     INFO - REFTEST INFO | Saved log: [CONTENT] MakeProgress
[task 2023-09-08T09:40:01.698Z] 09:40:01     INFO - REFTEST INFO | Saved log: [CONTENT] AfterPaintListener in file:///opt/worker/tasks/task_169416541256914/build/tests/jsreftest/tests/js/src/tests/jsreftest.html?test=non262/String/well-formed.js
[task 2023-09-08T09:40:01.699Z] 09:40:01     INFO - REFTEST INFO | Saved log: [CONTENT] MakeProgress: STATE_WAITING_FOR_SPELL_CHECKS
[task 2023-09-08T09:40:01.699Z] 09:40:01     INFO - REFTEST INFO | Saved log: [CONTENT] MakeProgress: STATE_WAITING_FOR_APZ_FLUSH
[task 2023-09-08T09:40:01.699Z] 09:40:01     INFO - REFTEST INFO | Saved log: [CONTENT] MakeProgress: APZ flush not required
[task 2023-09-08T09:40:01.699Z] 09:40:01     INFO - REFTEST INFO | Saved log: [CONTENT] MakeProgress
[task 2023-09-08T09:40:01.700Z] 09:40:01     INFO - REFTEST INFO | Saved log: [CONTENT] MakeProgress: STATE_WAITING_TO_FINISH
[task 2023-09-08T09:40:01.700Z] 09:40:01     INFO - REFTEST INFO | Saved log: [CONTENT] MakeProgress: waiting for updateCanvasPending
[task 2023-09-08T09:40:01.700Z] 09:40:01     INFO - REFTEST INFO | Saved log: [CONTENT] HandlePendingTasksAfterMakeProgress updating canvas
[task 2023-09-08T09:40:01.700Z] 09:40:01     INFO - REFTEST INFO | Saved log: [CONTENT] SendUpdateCanvasForEvent with 0 rects
[task 2023-09-08T09:40:01.700Z] 09:40:01     INFO - REFTEST INFO | Saved log: Updating canvas for invalidation
[task 2023-09-08T09:40:01.701Z] 09:40:01     INFO - REFTEST INFO | Saved log: [CONTENT] MakeProgress
[task 2023-09-08T09:40:01.701Z] 09:40:01     INFO - REFTEST INFO | Saved log: [CONTENT] MakeProgress: STATE_WAITING_TO_FINISH
[task 2023-09-08T09:40:01.701Z] 09:40:01     INFO - REFTEST INFO | Saved log: [CONTENT] MakeProgress: Doing sync flush to compositor
[task 2023-09-08T09:40:01.701Z] 09:40:01     INFO - REFTEST INFO | Saved log: [CONTENT] MakeProgress: Completed
[task 2023-09-08T09:40:01.702Z] 09:40:01     INFO - REFTEST INFO | Saved log: [CONTENT] RecordResult fired
[task 2023-09-08T09:40:01.702Z] 09:40:01     INFO - REFTEST INFO | Saved log: RecordResult fired
[task 2023-09-08T09:40:01.702Z] 09:40:01     INFO - REFTEST TEST-END | js/src/tests/non262/String/well-formed.js
[task 2023-09-08T09:40:01.706Z] 09:40:01     INFO - REFTEST TEST-START | js/src/tests/non262/String/normalize-generateddata-input.js

Comment 9

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

oh, for jsreftest I still need to check !xulRuntime.shell

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/15421ea0da78
Part 1: Turn on well-formed-unicode-strings by default in Browser and JS Shell. r=spidermonkey-reviewers,jandem
https://hg.mozilla.org/integration/autoland/rev/efa3c96edef1
Part 2: Update test262-update.py and test262 tests. r=spidermonkey-reviewers,dminor
https://hg.mozilla.org/integration/autoland/rev/ad52bd14218c
Part 3: Remove shell options --enable-well-formed-unicode-strings in js/src/tests/non262/String/well-formed.js. r=spidermonkey-reviewers,jandem

Comment 11

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/15421ea0da78
https://hg.mozilla.org/mozilla-central/rev/efa3c96edef1
https://hg.mozilla.org/mozilla-central/rev/ad52bd14218c

Comment 12

[Hamish Willee]

FF119 MDN docs for this can be tracked in https://github.com/mdn/content/issues/29301. Docs already existed so this was mostly compatibility data update and a release note.