1850758 - Don't show the Firefox View icon in permanent private browsing

Status: VERIFIED FIXED

(Firefox :: Firefox View, task)

Description

[Mike Kaply [:mkaply]]

When you select "don't remember history" and Firefox restarts, we shouldn't show the Firefox View icon because this is effectively private browsing.

(This is per PM)

Comment 1

[Mike Kaply [:mkaply]]

Here's the place where we hide view in temporary private browsing

https://searchfox.org/mozilla-central/source/browser/themes/shared/tabs.css#625

Comment 2

[Mike Kaply [:mkaply]]

Looks like permanent is set, it's just not used by any existing CSS.

https://searchfox.org/mozilla-central/source/browser/base/content/browser.js#8335

Comment 3

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1850758 - Hide the firefoxview buttons/entrypoints when in permanent private browsing. r?sclements!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1413faf09741
Hide the firefoxview buttons/entrypoints when in permanent private browsing. r=sclements,desktop-theme-reviewers,fxview-reviewers,dao

Comment 5

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 9352131 [details]
Bug 1850758 - Hide the firefoxview buttons/entrypoints when in permanent private browsing. r?sclements!

Request for Data Collection Renewal

** This form is for the renewal of an existing, reviewed data collection.**

** All questions are mandatory.
You must receive Data Review from a
Data Steward
on a filled-out Request before shipping your renewed data collection.**

1. Provide a link to the initial Data Collection Review Request for this collection.

• https://bug1809661.bmoattachments.org/attachment.cgi?id=9319384

2. When will this collection now expire?

• Firefox 132

3. Why was the initial period of collection insufficient?

• The events are sporadic and with significant outliers. We don't yet have a concrete plan for how to address the issue of unexpectedly long periods of time between adding a sync device and seeing synced tabs from that device. We want to continue to monitor this in the meantime.

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/1413faf09741

Comment 7

[Gabi Cheta [:Gabi] Desktop QA]

Verified as fixed in Firefox 119.0b7 and Firefox 120.0a1 Windows 10 x64, MacOS 12 and Ubuntu 22.