Closed Bug 1850823 Opened 2 years ago Closed 1 years ago

[wpt-sync] Sync PR 41723 - webkitgtk_minibrowser: fix getting binary_args parameter after ba277d1dd0

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox119 fixed)

Status:
RESOLVED FIXED
Milestone:
119 Branch
Tracking Flags:
Tracking Status
firefox119 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 41723 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/41723
Details from upstream follow.

Carlos Alberto Lopez Perez <clopez@igalia.com> wrote:

webkitgtk_minibrowser: fix getting binary_args parameter after ba277d1dd0

Commit ba277d1dd0 implemented a way of passing the browser binary_args for the wdspec session config but the way of getting this info for the browser webkigtk_minibrowser was not working.

Fix it by getting the info from the dictionary that the capabilities() function returns.

This was causing the following error on the CI:

Traceback (most recent call last):
  File "./wpt", line 10, in <module>
    wpt.main()
  File "/home/test/web-platform-tests/tools/wpt/wpt.py", line 233, in main
    rv = script(*args, **kwargs)
  File "/home/test/web-platform-tests/tools/wpt/run.py", line 894, in run
    rv = run_single(venv, **wptrunner_kwargs) > 0
  File "/home/test/web-platform-tests/tools/wpt/run.py", line 901, in run_single
    return wptrunner.start(**kwargs)
  File "/home/test/web-platform-tests/tools/wptrunner/wptrunner/wptrunner.py", line 536, in start
    rv = not run_tests(**kwargs)[0] or logged_critical.has_log
  File "/home/test/web-platform-tests/tools/wptrunner/wptrunner/wptrunner.py", line 473, in run_tests
    iter_success = run_test_iteration(test_status, test_loader, test_source,
  File "/home/test/web-platform-tests/tools/wptrunner/wptrunner/wptrunner.py", line 217, in run_test_iteration
    executor_kwargs = product.get_executor_kwargs(logger,
  File "/home/test/web-platform-tests/tools/wptrunner/wptrunner/browsers/webkitgtk_minibrowser.py", line 67, in executor_kwargs
    executor_kwargs["binary_args"] = capabilities["webkitgtk:browserOptions"]["args"]
TypeError: 'function' object is not subscriptable
[taskcluster 2023-08-28 01:26:39.572Z] === Task Finished ===
[taskcluster 2023-08-28 01:26:40.435Z] Unsuccessful task run with exit code: 1 completed in 164.001 seconds

Related: https://github.com/web-platform-tests/wpt/issues/40901

The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
Test result changes from PR not available.
Test result changes from PR not available.
Test result changes from PR not available.
Test result changes from PR not available.
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/91f866c859d0 [wpt PR 41723] - webkitgtk_minibrowser: fix getting binary_args parameter after ba277d1dd0, a=testonly

https://hg.mozilla.org/mozilla-central/rev/91f866c859d0

Status: NEW → RESOLVED
Closed: 1 years ago
status-firefox119: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 119 Branch
You need to log in before you can comment on or make changes to this bug.