Closed Bug 1850825 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 41720 - Relative color components are unitless, remove tests assuming otherwise

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
119 Branch
Tracking Flags:
Tracking Status
firefox119 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 41720 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/41720
Details from upstream follow.

Aaron Krajeski <aaronhk@chromium.org> wrote:

Relative color components are unitless, remove tests assuming otherwise

Some old spec examples combined color components (which are unitless)
with percentages and angles. Per spec, this is invalid:

https://drafts.css-houdini.org/css-typed-om-1/#numeric-typing

These examples were changed here, but remained in WPT:
https://github.com/w3c/csswg-drafts/commit/76d3f78c62cee437735a4b9ef5726307c7020b12
https://github.com/w3c/csswg-drafts/commit/c3de94f0d0d77246c6b23f5acea8dc7b86a71d5e

These invalid tests are moved to color-invalid-relative-color.html and
the valid, unitless versions of them that exist inside the spec are
included in color-valid-relative-color and color-computed-relative-color
instead: https://csswg.sesse.net/css-color-5/

Since tests are being removed here, virtual/stable needs to change.

Also, the Example numbers are removed from the test file because they
appear to change often. For example, they are now different on the
publication version, which is different from the current draft, which
is different from the test. It's probably not worthwhile to keep these
in sync.

Bug: 1447327
Change-Id: I8796b63db60e77a0be429360d11de0d9fd02b5f5
Reviewed-on: https://chromium-review.googlesource.com/4827664
WPT-Export-Revision: dfcfc804d101bf09f5ef952a8bab8160e5808b54

PR 41720 applied with additional changes from upstream: 559e0ee11b61f3347e97a66623a83a32fa41ba66, faf22d0d4125f7f9342bfac01289c26483be289a, 34fa76976c8bce2eaa2e3cb97c88b2358ffd71ae, 78a049065c391e18fca146aed90f59dc4cce3068, 76a3f72ff698c4c13e640054305e3597983652a3
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Test result changes from PR not available.
Test result changes from PR not available.
Test result changes from PR not available.
Test result changes from PR not available.
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cc83eb1381af [wpt PR 41720] - Relative color components are unitless, remove tests assuming otherwise, a=testonly https://hg.mozilla.org/integration/autoland/rev/0138b9aaaacc [wpt PR 41720] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/cc83eb1381af
https://hg.mozilla.org/mozilla-central/rev/0138b9aaaacc

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox119: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 119 Branch
You need to log in before you can comment on or make changes to this bug.