1850856 - Reopen all tabs in the Recently closed tabs menu doesn't open all the tabs

Status: RESOLVED FIXED

(Firefox :: Session Restore, defect, P1)

Description

[Sam Foster [:sfoster] (he/him)]

In the console there's an exception:

NS_ERROR_ILLEGAL_VALUE: Invalid index: not in the closed tabs SessionStore.sys.mjs:3829
    ssi_undoCloseTab resource:///modules/sessionstore/SessionStore.sys.mjs:3829
    ss_undoCloseTab resource:///modules/sessionstore/SessionStore.sys.mjs:480
    onRestoreAllTabsCommand resource:///modules/sessionstore/RecentlyClosedTabsAndWindowsMenuUtils.sys.mjs:130

This is a regression from bug 1819675. We pass in the index, but as each tab is re-opened, it gets removed from the _closedTabs array so the index gets out of bounds. We should just pass 0 so we successively open the first in the array until the array is empty.

Marking as low severity as this isn't a commonly used feature.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1819675

Comment 2

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1850856 - Fix tab indices when re-opening all closed tabs from the History menu.r?Dao!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ab72a15d7fba
Fix tab indices when re-opening all closed tabs from the History menu.r=sessionstore-reviewers,sclements

Comment 4

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 9351281 [details]
Bug 1850856 - Fix tab indices when re-opening all closed tabs from the History menu.r?Dao!

Beta/Release Uplift Approval Request

• User impact if declined: The "reopen all tabs" in the history > recently close tabs menu only opens some of the closed tabs.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: * Open and close several tabs
• Open History > Recently closed tabs menu and click "Reopen all tabs"
• Confirm all of the tabs are re-opened. The Recently closed tabs menu should now be empty and disabled.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The fix is constrained to the handler for the reopen all tabs menu item. There are no other entry points.
• String changes made/needed: None
• Is Android affected?: No

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ab72a15d7fba

Comment 6

[Monica Chiorean]

I was able to reproduce the issue on Win10x64 using FF build 118.0b5 (20230905175953).
Verified as fixed on Win10x64/Mac 12.6 using FF build 119.0a1(20230905215534).

Comment 7

[Pascal Chevrel:pascalc]

Comment on attachment 9351281 [details]
Bug 1850856 - Fix tab indices when re-opening all closed tabs from the History menu.r?Dao!

Approved for 118.0b6, thanks.

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/3891e696f0eb

Comment 9

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/3891e696f0eb

Comment 10

[Monica Chiorean]

Verified as fixed on Win10x64/Mac 12.6 using FF build 118.0b6 (20230907180212).

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9351281 [details]
Bug 1850856 - Fix tab indices when re-opening all closed tabs from the History menu.r?Dao!

Approved for 117.0.1

Comment 12

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/43cb4a8fe57e

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Added to the 117.0.1 release notes:

Fixed the Reopen all tabs option in the Recently closed tabs menu sometimes failing to open all tabs

Comment 14

[Monica Chiorean]

Verified as fixed on Win10x64/Mac 12.6 using FF build 117.0.1 (20230912013654).