1850869 - Testcases from bug 1671784 will still produce dotted lines if parts of the CSS are outside the visible part of the window (either by resizing the Browser window, or pinch-zooming)

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Mayank Bansal]

Open the two testcases from bug 1671784 ( https://bug1671784.bmoattachments.org/attachment.cgi?id=9182191 , https://bug1671784.bmoattachments.org/attachment.cgi?id=9337734 )
Pinch-zoom on them
Pan the zoomed-in page such that part of the css thingy is outside of the viewable portion of the tab

AR: Dotted lines can still be seen
ER: Not so

https://bugzilla.mozilla.org/show_bug.cgi?id=1671784#c42
:gw - Yes, let's track that in a separate bug - I know what the cause is, and it's a different issue than what was resolved in this bug.

Comment 1

[Mayank Bansal]

Attachment: about:support

Comment 2

[repovix575]

Attachment: FF-Nightly-119-0a1.png

Loading clip-path element that extends outside of the body (grey area is document only no body) with normal zoom also produces the artefacts. But kept inside the body it looks fine.

Nightly 119.0a1

Comment 3

[repovix575]

Add to previous, normal zoom level = without zooming :)

Comment 4

[Mayank Bansal]

Ah yes. To get the dotted lines, open the testcase and just resize the browser windows horizontally or vertically till parts of the css are outside the visible area. Zooming of any kind is not needed.

Comment 5

[Glenn Watson [:gw]]

I can reproduce this, and can see what's happening. When the primitive ends up intersecting with the viewport clip, there are now clips in a different coordinate system to the mask. For this case, we currently fall back to the old picture mask code, which has the existing issue. The best fix for this will be to handle these scenarios under the new clip-mask code paths, so that we don't need to fall back in this case.

Comment 6

[Glenn Watson [:gw]]

Attachment: Bug 1850869 - Support pictures that require source and target masks for correctness

Rather than selecting all clips to be drawn in the source or target space,
allow them to be separate masks when required. In the common case, the spaces
match and so all masks get drawn on to the picture surface. In the rare case
of a mask that requires drawing in source surface space, and a mask in a
parent non-aligned space, support rendering and applying them as separate masks.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/78bcc342f49c
Support pictures that require source and target masks for correctness r=gfx-reviewers,lsalzman

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/78bcc342f49c

Comment 9

[Mayank Bansal]

this is fixed on the latest nightly. Thanks!