1850933 - android 13 url selector in récents gives wrong address in app( the open Firefox in app option)

Status: RESOLVED FIXED

(Fenix :: Tabs, defect)

Description

[dennisooki]

Attachment: Screenshot_20230831-095956.png

User Agent: Mozilla/5.0 (Android 13; Mobile; rv:109.0) Gecko/119.0 Firefox/119.0

Steps to reproduce:

Open Firefox nightly version 119.0a1 in app, you will have to have set Firefox as the default browser app and enabled to open links inside other apps in Firefox,
Go to the récents view on your android phone, mine is android 13, Pixel launcher, try clicking on the link on the top right, it will give you an option to copy or share the link

Actual results:

The problem is that the link it gives you is not the link of the site you are actually in on the in app browser, but rather it is the link of the last open tab on actual Firefox

Expected results:

Correct link should be given by the browser , tried it with chrome, it gives the correct link

Comment 1

[jackyzy823]

Fenix handles onProvideAssistContent wrongly when current tab is CustomTabs.

Reference:

1. https://developer.android.com/guide/components/activities/recents#url-sharing
2. https://github.com/mozilla-mobile/firefox-android/blob/8af5f16e062c0871f362c41eb7b1a12c556a3c46/fenix/app/src/main/java/org/mozilla/fenix/HomeActivity.kt#L593-L597

Comment 2

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1850933 - Override onProvideAssistContent in ExternalAppBrowserActivity (#3473)

Comment 3

[BMO Github Automation]

Authored by https://github.com/jackyzy823
https://github.com/mozilla-mobile/firefox-android/commit/a904a580e6632a4adcd7446823f0ea2ad4a795e4
[main] Bug 1850933 - Override onProvideAssistContent in ExternalAppBrowserActivity

Comment 4

[Adina Petridean QA [:apetridean]]

Verified as fixed on Nightly 119.0a1 from 09/14 with Google Pixel 7 PRO (Android 14).

Comment 5

[Adina Petridean QA [:apetridean]]

Attachment: pixel.mp4