Closed Bug 1850972 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 41743 - Fix <color> transition for <paint>s (the 'fill' and 'stroke' properties)

Categories

(Core :: SVG, task, P4)

Product:
Core
Component:
SVG
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
119 Branch
Tracking Flags:
Tracking Status
firefox119 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 41743 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/41743
Details from upstream follow.

Fredrik Söderquist <fs@opera.com> wrote:

Fix <color> transition for <paint>s (the 'fill' and 'stroke' properties)

Add an implementation of MaybeMergeSingles() that matches what the one
in CSSColorInterpolationType does.

Fixed: 1476691
Change-Id: Ia6456346de52d3f11ad87d2446980600933ba83a
Reviewed-on: https://chromium-review.googlesource.com/4831492
WPT-Export-Revision: ff7d51b6e0ec5946573cdf546b917213ba7cc926

Component: web-platform-tests → SVG
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 192 subtests

Status Summary

Firefox

OK : 1
PASS: 120
FAIL: 72

Chrome

OK : 1
PASS: 148
FAIL: 44

Safari

OK : 1
PASS: 180
FAIL: 12

Links

GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

  • /css/css-fill-stroke/animation/fill-interpolation.html [wpt.fyi]
    • CSS Transitions: property <fill> from [color(srgb 0 0 0)] to [rgb(255 255 255)] at (0) should be [oklab(0 0 0)]: FAIL
    • CSS Transitions with transition: all: property <fill> from [color(srgb 0 0 0)] to [rgb(255 255 255)] at (0) should be [oklab(0 0 0)]: FAIL
    • CSS Animations: property <fill> from [color(srgb 0 0 0)] to [rgb(255 255 255)] at (0) should be [oklab(0 0 0)]: FAIL
    • Web Animations: property <fill> from [color(srgb 0 0 0)] to [rgb(255 255 255)] at (0) should be [oklab(0 0 0)]: FAIL
    • CSS Transitions: property <fill> from [color(srgb 0 0 0)] to [color(srgb 1 1 1)] at (-0.3) should be [oklab(0 0 0)]: FAIL
    • CSS Transitions: property <fill> from [color(srgb 0 0 0)] to [color(srgb 1 1 1)] at (0) should be [oklab(0 0 0)]: FAIL
    • CSS Transitions: property <fill> from [color(srgb 0 0 0)] to [color(srgb 1 1 1)] at (0.3) should be [oklab(0.3 0 0)]: FAIL
    • CSS Transitions: property <fill> from [color(srgb 0 0 0)] to [color(srgb 1 1 1)] at (0.6) should be [oklab(0.6 0 0)]: FAIL
    • CSS Transitions: property <fill> from [color(srgb 0 0 0)] to [color(srgb 1 1 1)] at (1) should be [oklab(1 0 0)]: FAIL
    • CSS Transitions with transition: all: property <fill> from [color(srgb 0 0 0)] to [color(srgb 1 1 1)] at (-0.3) should be [oklab(0 0 0)]: FAIL
    • CSS Transitions with transition: all: property <fill> from [color(srgb 0 0 0)] to [color(srgb 1 1 1)] at (0) should be [oklab(0 0 0)]: FAIL
    • CSS Transitions with transition: all: property <fill> from [color(srgb 0 0 0)] to [color(srgb 1 1 1)] at (0.3) should be [oklab(0.3 0 0)]: FAIL
    • CSS Transitions with transition: all: property <fill> from [color(srgb 0 0 0)] to [color(srgb 1 1 1)] at (0.6) should be [oklab(0.6 0 0)]: FAIL
    • CSS Transitions with transition: all: property <fill> from [color(srgb 0 0 0)] to [color(srgb 1 1 1)] at (1) should be [oklab(1 0 0)]: FAIL
    • CSS Animations: property <fill> from [color(srgb 0 0 0)] to [color(srgb 1 1 1)] at (-0.3) should be [oklab(0 0 0)]: FAIL
    • CSS Animations: property <fill> from [color(srgb 0 0 0)] to [color(srgb 1 1 1)] at (0) should be [oklab(0 0 0)]: FAIL
    • CSS Animations: property <fill> from [color(srgb 0 0 0)] to [color(srgb 1 1 1)] at (0.3) should be [oklab(0.3 0 0)]: FAIL
    • CSS Animations: property <fill> from [color(srgb 0 0 0)] to [color(srgb 1 1 1)] at (0.6) should be [oklab(0.6 0 0)]: FAIL
    • CSS Animations: property <fill> from [color(srgb 0 0 0)] to [color(srgb 1 1 1)] at (1) should be [oklab(1 0 0)]: FAIL
    • Web Animations: property <fill> from [color(srgb 0 0 0)] to [color(srgb 1 1 1)] at (-0.3) should be [oklab(0 0 0)]: FAIL
    • Web Animations: property <fill> from [color(srgb 0 0 0)] to [color(srgb 1 1 1)] at (0) should be [oklab(0 0 0)]: FAIL
    • Web Animations: property <fill> from [color(srgb 0 0 0)] to [color(srgb 1 1 1)] at (0.3) should be [oklab(0.3 0 0)]: FAIL
    • Web Animations: property <fill> from [color(srgb 0 0 0)] to [color(srgb 1 1 1)] at (0.6) should be [oklab(0.6 0 0)]: FAIL
    • Web Animations: property <fill> from [color(srgb 0 0 0)] to [color(srgb 1 1 1)] at (1) should be [oklab(1 0 0)]: FAIL

New Tests That Don't Pass

  • /css/css-fill-stroke/animation/fill-interpolation.html [wpt.fyi]
    • CSS Transitions: property <fill> from [rgb(0 0 0)] to [color(srgb 1 1 1)] at (-0.3) should be [oklab(0 0 0)]: FAIL (Chrome: FAIL, Safari: PASS)
    • CSS Transitions: property <fill> from [rgb(0 0 0)] to [color(srgb 1 1 1)] at (0) should be [oklab(0 0 0)]: FAIL (Chrome: FAIL, Safari: PASS)
    • CSS Transitions: property <fill> from [rgb(0 0 0)] to [color(srgb 1 1 1)] at (0.3) should be [oklab(0.3 0 0)]: FAIL (Chrome: FAIL, Safari: PASS)
    • CSS Transitions: property <fill> from [rgb(0 0 0)] to [color(srgb 1 1 1)] at (0.6) should be [oklab(0.6 0 0)]: FAIL (Chrome: FAIL, Safari: PASS)
    • CSS Transitions: property <fill> from [rgb(0 0 0)] to [color(srgb 1 1 1)] at (1) should be [oklab(1 0 0)]: FAIL (Chrome: FAIL, Safari: PASS)
    • CSS Transitions: property <fill> from [rgb(0 0 0)] to [color(srgb 1 1 1)] at (1.5) should be [oklab(1 0 0)]: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Transitions with transition: all: property <fill> from [rgb(0 0 0)] to [color(srgb 1 1 1)] at (-0.3) should be [oklab(0 0 0)]: FAIL (Chrome: FAIL, Safari: PASS)
    • CSS Transitions with transition: all: property <fill> from [rgb(0 0 0)] to [color(srgb 1 1 1)] at (0) should be [oklab(0 0 0)]: FAIL (Chrome: FAIL, Safari: PASS)
    • CSS Transitions with transition: all: property <fill> from [rgb(0 0 0)] to [color(srgb 1 1 1)] at (0.3) should be [oklab(0.3 0 0)]: FAIL (Chrome: FAIL, Safari: PASS)
    • CSS Transitions with transition: all: property <fill> from [rgb(0 0 0)] to [color(srgb 1 1 1)] at (0.6) should be [oklab(0.6 0 0)]: FAIL (Chrome: FAIL, Safari: PASS)
    • CSS Transitions with transition: all: property <fill> from [rgb(0 0 0)] to [color(srgb 1 1 1)] at (1) should be [oklab(1 0 0)]: FAIL (Chrome: FAIL, Safari: PASS)
    • CSS Transitions with transition: all: property <fill> from [rgb(0 0 0)] to [color(srgb 1 1 1)] at (1.5) should be [oklab(1 0 0)]: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Animations: property <fill> from [rgb(0 0 0)] to [color(srgb 1 1 1)] at (-0.3) should be [oklab(0 0 0)]: FAIL (Chrome: FAIL, Safari: PASS)
    • CSS Animations: property <fill> from [rgb(0 0 0)] to [color(srgb 1 1 1)] at (0) should be [oklab(0 0 0)]: FAIL (Chrome: FAIL, Safari: PASS)
    • CSS Animations: property <fill> from [rgb(0 0 0)] to [color(srgb 1 1 1)] at (0.3) should be [oklab(0.3 0 0)]: FAIL (Chrome: FAIL, Safari: PASS)
    • CSS Animations: property <fill> from [rgb(0 0 0)] to [color(srgb 1 1 1)] at (0.6) should be [oklab(0.6 0 0)]: FAIL (Chrome: FAIL, Safari: PASS)
    • CSS Animations: property <fill> from [rgb(0 0 0)] to [color(srgb 1 1 1)] at (1) should be [oklab(1 0 0)]: FAIL (Chrome: FAIL, Safari: PASS)
    • CSS Animations: property <fill> from [rgb(0 0 0)] to [color(srgb 1 1 1)] at (1.5) should be [oklab(1 0 0)]: FAIL (Chrome: FAIL, Safari: FAIL)
    • Web Animations: property <fill> from [rgb(0 0 0)] to [color(srgb 1 1 1)] at (-0.3) should be [oklab(0 0 0)]: FAIL (Chrome: FAIL, Safari: PASS)
    • Web Animations: property <fill> from [rgb(0 0 0)] to [color(srgb 1 1 1)] at (0) should be [oklab(0 0 0)]: FAIL (Chrome: FAIL, Safari: PASS)
    • Web Animations: property <fill> from [rgb(0 0 0)] to [color(srgb 1 1 1)] at (0.3) should be [oklab(0.3 0 0)]: FAIL (Chrome: FAIL, Safari: PASS)
    • Web Animations: property <fill> from [rgb(0 0 0)] to [color(srgb 1 1 1)] at (0.6) should be [oklab(0.6 0 0)]: FAIL (Chrome: FAIL, Safari: PASS)
    • Web Animations: property <fill> from [rgb(0 0 0)] to [color(srgb 1 1 1)] at (1) should be [oklab(1 0 0)]: FAIL (Chrome: FAIL, Safari: PASS)
    • Web Animations: property <fill> from [rgb(0 0 0)] to [color(srgb 1 1 1)] at (1.5) should be [oklab(1 0 0)]: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Transitions: property <fill> from [color(srgb 0 0 0)] to [rgb(255 255 255)] at (-0.3) should be [oklab(0 0 0)]: FAIL (Chrome: FAIL, Safari: PASS)
    • CSS Transitions: property <fill> from [color(srgb 0 0 0)] to [rgb(255 255 255)] at (0) should be [oklab(0 0 0)]: FAIL (Chrome: PASS, Safari: PASS)
    • CSS Transitions: property <fill> from [color(srgb 0 0 0)] to [rgb(255 255 255)] at (0.3) should be [oklab(0.3 0 0)]: FAIL (Chrome: FAIL, Safari: PASS)
    • CSS Transitions: property <fill> from [color(srgb 0 0 0)] to [rgb(255 255 255)] at (0.6) should be [oklab(0.6 0 0)]: FAIL (Chrome: FAIL, Safari: PASS)
    • CSS Transitions: property <fill> from [color(srgb 0 0 0)] to [rgb(255 255 255)] at (1) should be [oklab(1 0 0)]: FAIL (Chrome: FAIL, Safari: PASS)
    • CSS Transitions: property <fill> from [color(srgb 0 0 0)] to [rgb(255 255 255)] at (1.5) should be [oklab(1 0 0)]: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Transitions with transition: all: property <fill> from [color(srgb 0 0 0)] to [rgb(255 255 255)] at (-0.3) should be [oklab(0 0 0)]: FAIL (Chrome: FAIL, Safari: PASS)
    • CSS Transitions with transition: all: property <fill> from [color(srgb 0 0 0)] to [rgb(255 255 255)] at (0) should be [oklab(0 0 0)]: FAIL (Chrome: PASS, Safari: PASS)
    • CSS Transitions with transition: all: property <fill> from [color(srgb 0 0 0)] to [rgb(255 255 255)] at (0.3) should be [oklab(0.3 0 0)]: FAIL (Chrome: FAIL, Safari: PASS)
    • CSS Transitions with transition: all: property <fill> from [color(srgb 0 0 0)] to [rgb(255 255 255)] at (0.6) should be [oklab(0.6 0 0)]: FAIL (Chrome: FAIL, Safari: PASS)
    • CSS Transitions with transition: all: property <fill> from [color(srgb 0 0 0)] to [rgb(255 255 255)] at (1) should be [oklab(1 0 0)]: FAIL (Chrome: FAIL, Safari: PASS)
    • CSS Transitions with transition: all: property <fill> from [color(srgb 0 0 0)] to [rgb(255 255 255)] at (1.5) should be [oklab(1 0 0)]: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Animations: property <fill> from [color(srgb 0 0 0)] to [rgb(255 255 255)] at (-0.3) should be [oklab(0 0 0)]: FAIL (Chrome: FAIL, Safari: PASS)
    • CSS Animations: property <fill> from [color(srgb 0 0 0)] to [rgb(255 255 255)] at (0) should be [oklab(0 0 0)]: FAIL (Chrome: PASS, Safari: PASS)
    • CSS Animations: property <fill> from [color(srgb 0 0 0)] to [rgb(255 255 255)] at (0.3) should be [oklab(0.3 0 0)]: FAIL (Chrome: FAIL, Safari: PASS)
    • CSS Animations: property <fill> from [color(srgb 0 0 0)] to [rgb(255 255 255)] at (0.6) should be [oklab(0.6 0 0)]: FAIL (Chrome: FAIL, Safari: PASS)
    • CSS Animations: property <fill> from [color(srgb 0 0 0)] to [rgb(255 255 255)] at (1) should be [oklab(1 0 0)]: FAIL (Chrome: FAIL, Safari: PASS)
    • CSS Animations: property <fill> from [color(srgb 0 0 0)] to [rgb(255 255 255)] at (1.5) should be [oklab(1 0 0)]: FAIL (Chrome: FAIL, Safari: FAIL)
    • Web Animations: property <fill> from [color(srgb 0 0 0)] to [rgb(255 255 255)] at (-0.3) should be [oklab(0 0 0)]: FAIL (Chrome: FAIL, Safari: PASS)
    • Web Animations: property <fill> from [color(srgb 0 0 0)] to [rgb(255 255 255)] at (0) should be [oklab(0 0 0)]: FAIL (Chrome: PASS, Safari: PASS)
    • Web Animations: property <fill> from [color(srgb 0 0 0)] to [rgb(255 255 255)] at (0.3) should be [oklab(0.3 0 0)]: FAIL (Chrome: FAIL, Safari: PASS)
    • Web Animations: property <fill> from [color(srgb 0 0 0)] to [rgb(255 255 255)] at (0.6) should be [oklab(0.6 0 0)]: FAIL (Chrome: FAIL, Safari: PASS)
    • Web Animations: property <fill> from [color(srgb 0 0 0)] to [rgb(255 255 255)] at (1) should be [oklab(1 0 0)]: FAIL (Chrome: FAIL, Safari: PASS)
    • Web Animations: property <fill> from [color(srgb 0 0 0)] to [rgb(255 255 255)] at (1.5) should be [oklab(1 0 0)]: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Transitions: property <fill> from [color(srgb 0 0 0)] to [color(srgb 1 1 1)] at (-0.3) should be [oklab(0 0 0)]: FAIL (Chrome: PASS, Safari: PASS)
    • CSS Transitions: property <fill> from [color(srgb 0 0 0)] to [color(srgb 1 1 1)] at (0) should be [oklab(0 0 0)]: FAIL (Chrome: PASS, Safari: PASS)
    • CSS Transitions: property <fill> from [color(srgb 0 0 0)] to [color(srgb 1 1 1)] at (0.3) should be [oklab(0.3 0 0)]: FAIL (Chrome: PASS, Safari: PASS)
    • CSS Transitions: property <fill> from [color(srgb 0 0 0)] to [color(srgb 1 1 1)] at (0.6) should be [oklab(0.6 0 0)]: FAIL (Chrome: PASS, Safari: PASS)
    • CSS Transitions: property <fill> from [color(srgb 0 0 0)] to [color(srgb 1 1 1)] at (1) should be [oklab(1 0 0)]: FAIL (Chrome: PASS, Safari: PASS)
    • CSS Transitions: property <fill> from [color(srgb 0 0 0)] to [color(srgb 1 1 1)] at (1.5) should be [oklab(1 0 0)]: FAIL (Chrome: PASS, Safari: FAIL)
    • CSS Transitions with transition: all: property <fill> from [color(srgb 0 0 0)] to [color(srgb 1 1 1)] at (-0.3) should be [oklab(0 0 0)]: FAIL (Chrome: PASS, Safari: PASS)
    • CSS Transitions with transition: all: property <fill> from [color(srgb 0 0 0)] to [color(srgb 1 1 1)] at (0) should be [oklab(0 0 0)]: FAIL (Chrome: PASS, Safari: PASS)
    • CSS Transitions with transition: all: property <fill> from [color(srgb 0 0 0)] to [color(srgb 1 1 1)] at (0.3) should be [oklab(0.3 0 0)]: FAIL (Chrome: PASS, Safari: PASS)
    • CSS Transitions with transition: all: property <fill> from [color(srgb 0 0 0)] to [color(srgb 1 1 1)] at (0.6) should be [oklab(0.6 0 0)]: FAIL (Chrome: PASS, Safari: PASS)
    • CSS Transitions with transition: all: property <fill> from [color(srgb 0 0 0)] to [color(srgb 1 1 1)] at (1) should be [oklab(1 0 0)]: FAIL (Chrome: PASS, Safari: PASS)
    • CSS Transitions with transition: all: property <fill> from [color(srgb 0 0 0)] to [color(srgb 1 1 1)] at (1.5) should be [oklab(1 0 0)]: FAIL (Chrome: PASS, Safari: FAIL)
    • CSS Animations: property <fill> from [color(srgb 0 0 0)] to [color(srgb 1 1 1)] at (-0.3) should be [oklab(0 0 0)]: FAIL (Chrome: PASS, Safari: PASS)
    • CSS Animations: property <fill> from [color(srgb 0 0 0)] to [color(srgb 1 1 1)] at (0) should be [oklab(0 0 0)]: FAIL (Chrome: PASS, Safari: PASS)
    • CSS Animations: property <fill> from [color(srgb 0 0 0)] to [color(srgb 1 1 1)] at (0.3) should be [oklab(0.3 0 0)]: FAIL (Chrome: PASS, Safari: PASS)
    • CSS Animations: property <fill> from [color(srgb 0 0 0)] to [color(srgb 1 1 1)] at (0.6) should be [oklab(0.6 0 0)]: FAIL (Chrome: PASS, Safari: PASS)
    • CSS Animations: property <fill> from [color(srgb 0 0 0)] to [color(srgb 1 1 1)] at (1) should be [oklab(1 0 0)]: FAIL (Chrome: PASS, Safari: PASS)
    • CSS Animations: property <fill> from [color(srgb 0 0 0)] to [color(srgb 1 1 1)] at (1.5) should be [oklab(1 0 0)]: FAIL (Chrome: PASS, Safari: FAIL)
    • Web Animations: property <fill> from [color(srgb 0 0 0)] to [color(srgb 1 1 1)] at (-0.3) should be [oklab(0 0 0)]: FAIL (Chrome: PASS, Safari: PASS)
    • Web Animations: property <fill> from [color(srgb 0 0 0)] to [color(srgb 1 1 1)] at (0) should be [oklab(0 0 0)]: FAIL (Chrome: PASS, Safari: PASS)
    • Web Animations: property <fill> from [color(srgb 0 0 0)] to [color(srgb 1 1 1)] at (0.3) should be [oklab(0.3 0 0)]: FAIL (Chrome: PASS, Safari: PASS)
    • Web Animations: property <fill> from [color(srgb 0 0 0)] to [color(srgb 1 1 1)] at (0.6) should be [oklab(0.6 0 0)]: FAIL (Chrome: PASS, Safari: PASS)
    • Web Animations: property <fill> from [color(srgb 0 0 0)] to [color(srgb 1 1 1)] at (1) should be [oklab(1 0 0)]: FAIL (Chrome: PASS, Safari: PASS)
    • Web Animations: property <fill> from [color(srgb 0 0 0)] to [color(srgb 1 1 1)] at (1.5) should be [oklab(1 0 0)]: FAIL (Chrome: PASS, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/18e1ca7bcdaf [wpt PR 41743] - Fix <color> transition for <paint>s (the 'fill' and 'stroke' properties), a=testonly https://hg.mozilla.org/integration/autoland/rev/6249969ef31d [wpt PR 41743] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/18e1ca7bcdaf
https://hg.mozilla.org/mozilla-central/rev/6249969ef31d

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox119: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 119 Branch
You need to log in before you can comment on or make changes to this bug.