1850989 - Cleanup Wasm (tail) calls code

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, enhancement)

Description

[Yury Delendik (:yury)]

This is catch-all bug for follow up work. Mostly to tidy up the code base.

Items discovered e.g. during bug 1846762:

• some FunctionCompiler functions does not need isDeadCode check, e.g. at callRef
• still have if (!action) { return false; } return true;

More discoveries:

• Unused instrumentation: CodeOffset* fastCallOffset = &t; at e.g. wasmReturnCallIndirect
• Move temp register (in wasmCollapseFrame operation, e.g. e.g. static constexpr Register tempForRA = ABINonArgReg2;) into Assembler-xxx.h files, and give it more descriptive name.

Maybe more

Comment 1

[Yury Delendik (:yury)]

Attachment: Bug 1850989 - Replace superfluous inDeadCode checks with assert. r?rhunt

Comment 2

[Yury Delendik (:yury)]

Attachment: Bug 1850989 - Fix readability-simplify-boolean-expr in wasm code. r?rhunt

Address preexisting if (e) return false; return true; in wasm code.

readability-simplify-boolean-expr

Depends on D192117

Comment 3

[Yury Delendik (:yury)]

Attachment: Bug 1850989 - Make temp registers used in tail calls ops global. r?rhunt

Depends on D192118

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/61f7bb9a3678
Replace superfluous inDeadCode checks with assert. r=rhunt
https://hg.mozilla.org/integration/autoland/rev/f06d3ef22e4c
Fix readability-simplify-boolean-expr in wasm code. r=rhunt
https://hg.mozilla.org/integration/autoland/rev/b837f069626d
Make temp registers used in tail calls ops global. r=rhunt

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/61f7bb9a3678
https://hg.mozilla.org/mozilla-central/rev/f06d3ef22e4c
https://hg.mozilla.org/mozilla-central/rev/b837f069626d